IDENTITY opt-in config Issue: #233 #715
Open
Jatanasio wants to merge 4 commits intoash-project:mainfrom
Open
Conversation
Contributor
|
I like this! The one thing I would like to change is that instead of storing at the top level of the snapshot, we should store within each attribute by overriding the type. We can set the type to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Refactored some of the functions to opt-in to using identity columns using the identity_columns_default DSL rather than simply using serial/bigserial columns. Also created migration tests to test opting for identity columns in various scenarios as well as falling back to serial when identity is not opted into.