Skip to content

EXT4: Fix the construction of the path#666

Merged
wlan0 merged 6 commits intoapple:mainfrom
dkovba:path
Apr 9, 2026
Merged

EXT4: Fix the construction of the path#666
wlan0 merged 6 commits intoapple:mainfrom
dkovba:path

Conversation

@dkovba
Copy link
Copy Markdown
Contributor

@dkovba dkovba commented Apr 8, 2026

Fixes the construction of the path and removed unnecessary code. Fixes the added failing test:

✘ Test fileTreeNodePathWithAbsoluteRoot() recorded an issue at TestEXT4Reader+IO.swift:600:9: Expectation failed: (dirPtr.pointee.path → /) == (FilePath("/dir") → /dir)
✘ Test fileTreeNodePathWithAbsoluteRoot() recorded an issue at TestEXT4Reader+IO.swift:601:9: Expectation failed: (filePtr.pointee.path → /) == (FilePath("/dir/file") → /dir/file)
✘ Test fileTreeNodePathWithAbsoluteRoot() failed after 0.001 seconds with 2 issues.

@dkovba dkovba requested a review from wlan0 April 8, 2026 20:56
@dcantah dcantah changed the title Fix the construction of the path EXT4: Fix the construction of the path Apr 8, 2026
@wlan0 wlan0 merged commit 340c31d into apple:main Apr 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants