Skip to content

Remove the incorrect check for visited inodes#659

Merged
crosbymichael merged 2 commits intoapple:mainfrom
dkovba:symlinks
Apr 9, 2026
Merged

Remove the incorrect check for visited inodes#659
crosbymichael merged 2 commits intoapple:mainfrom
dkovba:symlinks

Conversation

@dkovba
Copy link
Copy Markdown
Contributor

@dkovba dkovba commented Apr 7, 2026

Removes the incorrect check for visited inodes. Fixes the added failing tests:

✘ Test sameAbsoluteSymlinkFollowedTwice() recorded an issue at TestEXT4Reader+IO.swift:502:6: Caught error: symlink loop while resolving: target/../symlink/file.txt
✘ Test sameAbsoluteSymlinkFollowedTwice() failed after 0.009 seconds with 1 issue.

✘ Test sameRelativeSymlinkFollowedTwice() recorded an issue at TestEXT4Reader+IO.swift:516:6: Caught error: symlink loop while resolving: ../target/../symlink/file.txt
✘ Test sameRelativeSymlinkFollowedTwice() failed after 0.010 seconds with 1 issue.

@dkovba dkovba requested a review from wlan0 April 7, 2026 17:17
@crosbymichael crosbymichael merged commit b2be8de into apple:main Apr 9, 2026
3 checks passed
@dkovba dkovba deleted the symlinks branch April 9, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants