Skip to content

Regenerate protobufs#517

Closed
dkovba wants to merge 2 commits intoapple:mainfrom
dkovba:protobufs
Closed

Regenerate protobufs#517
dkovba wants to merge 2 commits intoapple:mainfrom
dkovba:protobufs

Conversation

@dkovba
Copy link
Copy Markdown
Contributor

@dkovba dkovba commented Feb 6, 2026

This resolves warnings like this in projects that are using Containerization:

.../Sources/Containerization/SandboxContext/SandboxContext.pb.swift:1451:65: warning: 'init(dictionaryLiteral:)' is deprecated: Please regenerate your .pb.swift files with the current version of the SwiftProtobuf protoc plugin. [#DeprecatedDeclaration]
1449 | 
1450 | extension Com_Apple_Containerization_Sandbox_V3_StatCategory: SwiftProtobuf._ProtoNameProviding {
1451 |   public static let _protobuf_nameMap: SwiftProtobuf._NameMap = [
     |                                                                 `- warning: 'init(dictionaryLiteral:)' is deprecated: Please regenerate your .pb.swift files with the current version of the SwiftProtobuf protoc plugin. [#DeprecatedDeclaration]
1452 |     0: .same(proto: "STAT_CATEGORY_UNSPECIFIED"),
1453 |     1: .same(proto: "STAT_CATEGORY_PROCESS"),

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Feb 6, 2026

This should be apart of #379 if we wanna finally review it

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Feb 6, 2026

Funnily enough v2 has warnings as well

@dkovba
Copy link
Copy Markdown
Contributor Author

dkovba commented Feb 6, 2026

This should be apart of #379 if we wanna finally review it

Either works, assuming warnings can be solved in v2.

@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented Feb 7, 2026

Right now #379 fails hawkeye with:

2026-02-06T09:55:40.039491+00:00[GMT]  INFO hawkeye::subcommand: subcommand.rs:188 All files have proper header.
the following files require formatting or license headers:
Sources/Containerization/SandboxContext/SandboxContext.grpc.swift
Sources/Containerization/SandboxContext/SandboxContext.pb.swift

I think I'll have free time this weekend to finally do the last bit of review on that PR

@dcantah
Copy link
Copy Markdown
Member

dcantah commented Feb 7, 2026

There's a "bug" in the deps on that pr that cause warnings on 6.2, so if we want a warning free build that isn't the move.

@jglogan jglogan mentioned this pull request Feb 9, 2026
@jglogan
Copy link
Copy Markdown
Contributor

jglogan commented Mar 13, 2026

We regenerated protobufs in #578. I also updated swift-protobuf to the latest version which gets rid of all the annoying deprecation warnings around things like URL.path.

@jglogan jglogan closed this Mar 13, 2026
@dkovba dkovba deleted the protobufs branch March 13, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants