[epoch] Remove non-UTC epoch logic

[john-bodley]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

As @agrawaldevesh correctly identified in #6721 previously we were computing the Unix timestamp for the right-hand-side (RHS) of the temporal filter condition using the local time zone as opposed to UTC which is the definition of a Unix timestamp (or epoch).

@agrawaldevesh's change was behind a feature flag and disabled by default however this clearly is a bug and I sense we should remedy the problem by merely replacing the previously incorrect logic. Note I strongly believe users were probably unaware of the issue as Unix timestamps aren't human readable.

TEST PLAN

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

to: @agrawaldevesh @betodealmeida @michellethomas @mistercrunch @villebro

[john-bodley]

#7656

[codecov-io]

Codecov Report

Merging #7667 into master will decrease coverage by 8.34%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master    #7667      +/-   ##
==========================================
- Coverage   73.92%   65.58%   -8.35%     
==========================================
  Files         106      435     +329     
  Lines       11444    21749   +10305     
  Branches        0     2394    +2394     
==========================================
+ Hits         8460    14264    +5804     
- Misses       2984     7364    +4380     
- Partials        0      121     +121

Impacted Files	Coverage Δ
superset/config.py	93.97% <ø> (-0.08%)	⬇️
superset/connectors/sqla/models.py	82.39% <75%> (+0.41%)	⬆️
superset/connectors/sqla/views.py	63.15% <0%> (-2.14%)	⬇️
superset/connectors/druid/views.py	66.21% <0%> (-1.53%)	⬇️
superset/views/core.py	72.87% <0%> (-0.19%)	⬇️
superset/db_engine_specs/kylin.py
superset/db_engine_specs/mysql.py
superset/db_engine_specs/mssql.py
superset/db_engine_specs/sqlite.py
... and 373 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541db94...e666244. Read the comment docs.

[villebro]

LGTM, but perhaps add a comment in the changelog in case someone has logic depending on the incorrect epoch format?

[etr2460]

LGTM

[etr2460]

nit: remove the "to" before reference

a change to make Unix (epoch) timestamps reference UTC as opposed to the local time zone.

[john-bodley]

@agrawaldevesh are you onboard with this change?

[agrawaldevesh]

Go for it ! I only introduced the flag since I did not want to break existing use cases. I have no issues with making this be default

…

On Mon, Jun 10, 2019 at 5:02 PM John Bodley ***@***.***> wrote: @agrawaldevesh <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_agrawaldevesh&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=Z3aBmCzO3AGueh3ZEPa3n4ujmbgsJJDE-x0U4W8t_Us&m=O_sBQHDGT4uYRBuD0MeJgRcwajjdTrjVL114CzrCW6A&s=jbT8jeF_xUkzsr1n0uEA-H-vfQW3Vu6ryUdUELUU7vQ&e=> are you onboard with this change? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dsuperset_pull_7667-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAE44R77I3WBGYPB5XWLSMQLPZ3TRVA5CNFSM4HVJ6VW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLRTFI-23issuecomment-2D500636053&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=Z3aBmCzO3AGueh3ZEPa3n4ujmbgsJJDE-x0U4W8t_Us&m=O_sBQHDGT4uYRBuD0MeJgRcwajjdTrjVL114CzrCW6A&s=3Z1HFovjiRBXcX0cRTa1BCbVGz5q-yVMM9B9u7jB_yM&e=>, or mute the thread <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AE44R77CTI7IHEM57QUNF2LPZ3TRVANCNFSM4HVJ6VWQ&d=DwMCaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=Z3aBmCzO3AGueh3ZEPa3n4ujmbgsJJDE-x0U4W8t_Us&m=O_sBQHDGT4uYRBuD0MeJgRcwajjdTrjVL114CzrCW6A&s=S3v_GuSJtAWrrOdirnt1nz9dQNSS9KGhn1jIfdjd24I&e=> .