Allow user to force refresh metadata by youngyjd · Pull Request #5933 · apache/superset

youngyjd · 2018-09-19T19:47:18Z

Several changes in this PR:

Introduced "metadata_cache_timeout": {} setting in extra of a database configuration. If schema_cache_timeout is unset in the field, cache will not be enabled for the metadata fetch of this database. If it is set to 0, cache will never time out.
Added a button to sqllab UI which allows user to refetch schemas metadata and force refresh cache if cache is enabled.
Added a new component which is called RefreshLabel. It is similar to CacheLabel but simpler. Not sure if we need to integrate the two labels into one component and not sure how to implement if so. Any suggestion is welcome.

Next step:

Implement similar things on fetching table list.

codecov-io · 2018-09-20T03:54:23Z

Codecov Report

Merging #5933 into master will increase coverage by 14.31%.
The diff coverage is 63.63%.

@@             Coverage Diff             @@
##           master    #5933       +/-   ##
===========================================
+ Coverage   63.52%   77.83%   +14.31%     
===========================================
  Files         393       46      -347     
  Lines       23667     9434    -14233     
  Branches     2638        0     -2638     
===========================================
- Hits        15034     7343     -7691     
+ Misses       8620     2091     -6529     
+ Partials       13        0       -13

Impacted Files	Coverage Δ
superset/models/core.py	`85.1% <100%> (+0.09%)`	⬆️
superset/db_engine_specs.py	`55.87% <50%> (+1.04%)`	⬆️
superset/cache_util.py	`54.28% <56.25%> (+0.11%)`	⬆️
superset/views/core.py	`73.9% <60%> (+0.16%)`	⬆️
superset/utils.py	`88.39% <0%> (-0.9%)`	⬇️
superset/connectors/sqla/views.py	`64.34% <0%> (ø)`	⬆️
superset/views/base.py	`68% <0%> (ø)`	⬆️
superset/viz.py	`81.04% <0%> (ø)`	⬆️
superset/assets/src/components/Checkbox.jsx
... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5811a26...7e97ac8. Read the comment docs.

youngyjd · 2018-09-20T05:20:18Z

@mistercrunch @betodealmeida

betodealmeida

Looks great, @youngyjd! I have just a couple comments, and it would be good to preserve the old endpoint.

Also — and this can be done on a separate PR, just curious — how hard would it be to show in the tooltip when the schemas were cached?

betodealmeida · 2018-10-03T18:04:27Z


 ```bash
-cd superset/assets/javascripts
+cd superset/assets/spec


Thank you for fixing this!

betodealmeida · 2018-10-03T18:08:55Z

+    def schemas(self, db_id, force_refresh):
        db_id = int(db_id)
+        force_refresh = force_refresh.lower() == 'true'
+        print(force_refresh)


betodealmeida · 2018-10-03T18:16:14Z

            '#sqlalchemy.schema.MetaData) call.<br/>'
-            '2. The ``schemas_allowed_for_csv_upload`` is a comma separated list '
+            '2. The ``metadata_cache_timeout`` is a cache timeout setting '
+            'in second for metadata fetch of this database. Specify it as '


s/second/seconds/

betodealmeida · 2018-10-03T18:21:42Z

+            enable_cache=enable_cache,
+            cache_timeout=(self.get_extra().
+                           get('metadata_cache_timeout', {}).
+                           get('schema_cache_timeout')),


This is a bit hard to read — at first I thought these were 3 arguments being passed, and get was a function.

Personally I would rewrite this as:

extra = self.get_extra() try: cache_timeout = extra['metadata_cache_timeout']['schema_cache_timeout'] except KeyError: cache_timeout = None

There's a proposal that would allow this to be written as:

cache_timeout = self.get_extra()?['metadata_cache_timeout']?['schema_cache_timeout']

betodealmeida · 2018-10-04T17:17:56Z



-def memoized_func(timeout=5 * 60, key=view_cache_key):
+def default_timetout(*unused_args, **unused_kwargs):


default_timeout

betodealmeida · 2018-10-04T17:18:10Z

+    return True
+
+
+def memoized_func(timeout=default_timetout,


default_timeout

betodealmeida · 2018-10-04T17:30:49Z

-    @expose('/schemas/<db_id>/')
-    def schemas(self, db_id):
+    @expose('/schemas/<db_id>/<force_refresh>/')
+    def schemas(self, db_id, force_refresh):


It would be good to preserve the old behavior, just in case something is using the API. I think you can do here:

@expose('/schemas/<db_id>/<force_refresh>/') @expose('/schemas/<db_id>/') def schemas(self, db_id, force_refresh=True):

And it would handle both cases.

youngyjd · 2018-10-08T23:29:28Z

Comments addressed. PTAL @betodealmeida

betodealmeida · 2018-10-09T03:25:11Z

Awesome, thanks! :)

* Allow user to force refresh metadata * fix javascript test error * nit * fix styling * allow custom cache timeout configuration on any database * minor improvement * nit * fix test * nit * preserve the old endpoint

* Allow user to force refresh metadata * fix javascript test error * nit * fix styling * allow custom cache timeout configuration on any database * minor improvement * nit * fix test * nit * preserve the old endpoint (cherry picked from commit 712c1aa)

* Allow user to force refresh metadata * fix javascript test error * nit * fix styling * allow custom cache timeout configuration on any database * minor improvement * nit * fix test * nit * preserve the old endpoint (cherry picked from commit 712c1aa) (cherry picked from commit a3441c1)

* Allow user to force refresh metadata * fix javascript test error * nit * fix styling * allow custom cache timeout configuration on any database * minor improvement * nit * fix test * nit * preserve the old endpoint

youngyjd changed the title ~~Allow user to force refresh metadata~~ Allow user to force refresh metadata and Cache Hive schema metadata Sep 19, 2018

youngyjd force-pushed the introduce-cache-in-metadata-fetch branch 5 times, most recently from 5c4ea1b to 8ef4c71 Compare September 20, 2018 03:29

youngyjd changed the title ~~Allow user to force refresh metadata and Cache Hive schema metadata~~ Allow user to force refresh metadata Sep 20, 2018

youngyjd force-pushed the introduce-cache-in-metadata-fetch branch from e589031 to 6191dbd Compare September 20, 2018 21:59

youngyjd added 8 commits September 21, 2018 12:15

Allow user to force refresh metadata

d3da1f9

fix javascript test error

cbf905f

nit

67a3207

fix styling

d14e736

allow custom cache timeout configuration on any database

05069a2

minor improvement

03b45fc

nit

cec36a2

fix test

3a3658f

youngyjd force-pushed the introduce-cache-in-metadata-fetch branch 7 times, most recently from 14b7eac to adb42e6 Compare September 24, 2018 18:32

nit

8416ca8

youngyjd force-pushed the introduce-cache-in-metadata-fetch branch from adb42e6 to 8416ca8 Compare September 24, 2018 20:51

betodealmeida requested changes Oct 4, 2018

View reviewed changes

preserve the old endpoint

7e97ac8

betodealmeida approved these changes Oct 9, 2018

View reviewed changes

betodealmeida merged commit 712c1aa into apache:master Oct 9, 2018

youngyjd mentioned this pull request Oct 12, 2018

allow cache and force refresh on table list #6078

Merged

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 First shipped in 0.28.0 labels Feb 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow user to force refresh metadata#5933

Allow user to force refresh metadata#5933
betodealmeida merged 10 commits intoapache:masterfrom
youngyjd:introduce-cache-in-metadata-fetch

youngyjd commented Sep 19, 2018 •

edited

Loading

Uh oh!

codecov-io commented Sep 20, 2018 •

edited

Loading

Uh oh!

youngyjd commented Sep 20, 2018

Uh oh!

betodealmeida left a comment

Uh oh!

betodealmeida Oct 3, 2018

Uh oh!

betodealmeida Oct 3, 2018

Uh oh!

betodealmeida Oct 3, 2018

Uh oh!

betodealmeida Oct 3, 2018

Uh oh!

betodealmeida Oct 4, 2018

Uh oh!

betodealmeida Oct 4, 2018

Uh oh!

betodealmeida Oct 4, 2018

Uh oh!

youngyjd commented Oct 8, 2018

Uh oh!

betodealmeida commented Oct 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants



		def memoized_func(timeout=5 * 60, key=view_cache_key):
		def default_timetout(unused_args, *unused_kwargs):

Conversation

youngyjd commented Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Several changes in this PR:

Next step:

Uh oh!

codecov-io commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

youngyjd commented Sep 20, 2018

Uh oh!

betodealmeida left a comment

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 3, 2018

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

betodealmeida Oct 4, 2018

Choose a reason for hiding this comment

Uh oh!

youngyjd commented Oct 8, 2018

Uh oh!

betodealmeida commented Oct 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

youngyjd commented Sep 19, 2018 •

edited

Loading

codecov-io commented Sep 20, 2018 •

edited

Loading