chore: remove deprecated api /superset/tables/<int:db_id>/...

[dpgaspar]

SUMMARY

Removes old deprecated API /superset/tables/<int:db_id>/... use /api/v1/database/<int:pk>/tables/ instead

Effort on removing deprecated APIs from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24342 (b40fefc) into master (2df699c) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b40fefc differs from pull request most recent head e04c657. Consider uploading reports for the commit e04c657 to get more accurate results

@@            Coverage Diff             @@
##           master   #24342      +/-   ##
==========================================
- Coverage   69.08%   69.06%   -0.03%     
==========================================
  Files        1903     1903              
  Lines       74590    74564      -26     
  Branches     8107     8107              
==========================================
- Hits        51534    51500      -34     
- Misses      20945    20953       +8     
  Partials     2111     2111              

Flag	Coverage Δ
hive	53.80% <ø> (+0.01%)	⬆️
mysql	79.35% <ø> (-0.04%)	⬇️
postgres	79.42% <ø> (-0.03%)	⬇️
presto	53.72% <ø> (+0.01%)	⬆️
python	83.34% <ø> (-0.04%)	⬇️
sqlite	77.95% <ø> (-0.04%)	⬇️
unit	54.21% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/core.py	75.68% <ø> (-0.36%)	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

Could you move this to the breaking changes section and add the PR number?

[dpgaspar]

this is strange I think we used to only have Next and potential downtime, since all that lands on Next would somewhat be a minor breaking change. What's the difference between Next and Breaking changes on this context?

[michael-s-molina]

The difference is that in Next we add things that are not breaking changes but might be helpful when upgrading.

[michael-s-molina]

I think is just a form of separating things you should really be careful when upgrading from things you might find useful or interesting.

[villebro]

LGTM, but I suggest we wait for #24344 first and make sure the perf issue is fixed on both code paths before merging this.

[villebro]

FYI @dpgaspar #24344 is now merged

[michael-s-molina]

LGTM