fix: db validate parameters permission

[dpgaspar]

SUMMARY

Restricts access to:

• /api/v1/database/validate_parameters/, changes the necessary permission from can_read to can_write on Database

• /api/v1/database/test_connection/, changes the necessary permission from can_read to can_write on Database

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24185 (cee1529) into master (18d2257) will not change coverage.
The diff coverage is n/a.

❗ Current head cee1529 differs from pull request most recent head 4e2fd6f. Consider uploading reports for the commit 4e2fd6f to get more accurate results

@@           Coverage Diff           @@
##           master   #24185   +/-   ##
=======================================
  Coverage   57.24%   57.24%           
=======================================
  Files        1957     1957           
  Lines       75624    75624           
  Branches     8223     8223           
=======================================
  Hits        43294    43294           
  Misses      30222    30222           
  Partials     2108     2108           

Flag	Coverage Δ
hive	53.39% <ø> (ø)
presto	53.32% <ø> (ø)
python	59.93% <ø> (ø)
unit	53.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/constants.py	100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[betodealmeida]

Do we need to update any of the tests? Or add a new one?

[dpgaspar]

Do we need to update any of the tests? Or add a new one?

Good point! probably a test to make sure Gamma user's don't access these. I'll add it

[john-bodley]

@dpgaspar why are we changing these from can_read to can_write for both these endpoints given (in theory) they're read requests, i.e., the underlying model is not being augmented.

Maybe providing a more detailed PR description would be helpful.

[villebro]

Thanks for this fix 👍

[michael-s-molina]

@dpgaspar Can you add a note in the Breaking Changes section for this change?