fix: import should accept old keys#17330
Merged
betodealmeida merged 3 commits intoapache:masterfrom Nov 3, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17330 +/- ##
==========================================
- Coverage 77.15% 76.97% -0.19%
==========================================
Files 1037 1036 -1
Lines 55639 55686 +47
Branches 7612 7627 +15
==========================================
- Hits 42930 42862 -68
- Misses 12459 12568 +109
- Partials 250 256 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
approved these changes
Nov 3, 2021
betodealmeida
force-pushed
the
ch27296
branch
from
3c7c3b1 to
843ea31
Compare
eschutho
pushed a commit
that referenced
this pull request
Nov 22, 2021
* fix: import should accept old keys * Fix lint * Preserve V1 schema
eschutho
added a commit
to preset-io/superset
that referenced
this pull request
Dec 15, 2021
This reverts commit 0b8507f.
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
* fix: import should accept old keys * Fix lint * Preserve V1 schema
mistercrunch
added
🍒 1.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
#16756 renamed a few fields on a versioned schema, breaking import/export, since old exports are no longer valid.
I reverted the schema to the original V1, and fixed export to produce the original schema. I also fixed the import to support the new keys, since exports might've been made with the incorrect schema.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION