fix: handle constraints in db migration for MySQL 8#17274
fix: handle constraints in db migration for MySQL 8#17274exemplary-citizen wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17274 +/- ##
==========================================
- Coverage 77.02% 76.95% -0.08%
==========================================
Files 1037 1037
Lines 55629 55629
Branches 7594 7594
==========================================
- Hits 42851 42807 -44
- Misses 12528 12572 +44
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@exemplary-citizen did you test this on an existing install with MySQL 8? I don't think it will work because the constraint will already be there for existing installations, and for new installations it will be created before this migration runs. |
|
I think we need to do something like this: #17275 |
|
@betodealmeida you're right it is still failing. closing in favor of your PR |
SUMMARY
fix for db migration issue introduced in #16756
TESTING INSTRUCTIONS
Watch CI and any suggestions from reviewers
cc: @betodealmeida