chore: upgrade to Node 16#16809
Merged
villebro merged 3 commits intoapache:masterfrom Sep 25, 2021
Merged
Conversation
villebro
force-pushed
the
villebro/node-16
branch
from
084a41e to
2d74ac9
Compare
villebro
force-pushed
the
villebro/node-16
branch
2 times, most recently
from
ee99dfa to
b6c905e
Compare
villebro
force-pushed
the
villebro/node-16
branch
from
b6c905e to
902e57f
Compare
Codecov Report
@@ Coverage Diff @@
## master #16809 +/- ##
==========================================
- Coverage 76.89% 76.88% -0.01%
==========================================
Files 1005 1005
Lines 54169 54166 -3
Branches 7456 7456
==========================================
- Hits 41653 41648 -5
- Misses 12272 12273 +1
- Partials 244 245 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
Author
|
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true |
Contributor
|
@villebro Ephemeral environment spinning up at http://34.220.179.110:8080. Credentials are |
zhaoyongjie
approved these changes
Sep 24, 2021
Member
zhaoyongjie
left a comment
zhaoyongjie
left a comment
There was a problem hiding this comment.
Tested in local. Tested linked superset-ui repo.
LGTM
Contributor
|
Ephemeral environment shutdown and build artifacts deleted. |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* chore: upgrade to Node 16 * add docs * fix test
ktmud
added a commit
that referenced
this pull request
Nov 20, 2021
#16809 updated node version but it didn't update nvmrc.
9 tasks
villebro
pushed a commit
that referenced
this pull request
Nov 23, 2021
#16809 updated node version but it didn't update nvmrc.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* chore: upgrade to Node 16 * add docs * fix test
AAfghahi
pushed a commit
that referenced
this pull request
Jan 10, 2022
#16809 updated node version but it didn't update nvmrc.
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
With Node 16 being the currently recommended version since 2021-04-20 and becoming the LTS supported version on 2021-10-26, it makes sense to migrate to this version to get all the benefits available in the new release:
https://medium.com/the-node-js-collection/node-js-16-available-now-7f5099a97e70
Also removes the workaround for pulling in
npm@7in #16748 (npm 7 ships by default with Node 16)This PR also fixes some tests that were previously passing but contained unhandled promise rejections. Previously these only emitted warnings, but as of Node 15 these caused errors.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION