Skip to content

fix: allow reports to update query_context#16303

Merged
betodealmeida merged 1 commit intoapache:masterfrom
preset-io:ch22197
Aug 17, 2021
Merged

fix: allow reports to update query_context#16303
betodealmeida merged 1 commit intoapache:masterfrom
preset-io:ch22197

Conversation

@betodealmeida
Copy link
Copy Markdown
Member

SUMMARY

When updating query_context we shouldn't check if the user has permissions to overwrite the chart, since we allow any user to do that operation:

# Check ownership; when only updating query context we ignore
# ownership so the update can be performed by report workers
if not is_query_context_update(self._properties):
try:
check_ownership(self._model)
except SupersetSecurityException as ex:
raise ChartForbiddenError() from ex

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Aug 17, 2021
@betodealmeida betodealmeida merged commit 7a284bb into apache:master Aug 17, 2021
betodealmeida added a commit to preset-io/superset that referenced this pull request Aug 17, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 19, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset:2021.31 size/XS 🚢 1.4.0 First shipped in 1.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants