fix: allow reports to update query_context#16303
Merged
betodealmeida merged 1 commit intoapache:masterfrom Aug 17, 2021
Merged
Conversation
eschutho
approved these changes
Aug 17, 2021
betodealmeida
added a commit
to preset-io/superset
that referenced
this pull request
Aug 17, 2021
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 19, 2021
(cherry picked from commit 7a284bb)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When updating
query_contextwe shouldn't check if the user has permissions to overwrite the chart, since we allow any user to do that operation:superset/superset/charts/commands/update.py
Lines 87 to 93 in b87e0b3
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
N/A
ADDITIONAL INFORMATION