fix(dashboard): cross filter chart highlight when filters badge icon clicked by kgabryje · Pull Request #16233 · apache/superset

kgabryje · 2021-08-12T14:50:50Z

SUMMARY

This PR fixes highlighting the chart emitting a cross filter when magnifier icon in filter's badge is clicked. Before, nothing happened when icon was clicked. Now it highlights and scrolls the chart to view and changes tab if needed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see #16220
After:

Screen.Recording.2021-08-12.at.16.43.52.mov

TESTING INSTRUCTIONS

Enable cross filtering feature flag
Open a dashboard that contains charts that can emit cross filters
Emit cross filter
Click filters badge on another chart and click magnifier icon of the chart that emits the cross filter
Verify that the source chart gets highlighted and scrolled into view

ADDITIONAL INFORMATION

Has associated issue: fixes [cross filter] clicking on the magnifier in cross filter indicator did not bring to emitting chart #16220
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

CC @junlincc @jinghua-qa

…pressed

codecov · 2021-08-12T16:31:54Z

Codecov Report

Merging #16233 (3dcca18) into master (b61c34f) will increase coverage by 0.02%.
The diff coverage is 63.15%.

❗ Current head 3dcca18 differs from pull request most recent head ef33f65. Consider uploading reports for the commit ef33f65 to get more accurate results

@@            Coverage Diff             @@
##           master   #16233      +/-   ##
==========================================
+ Coverage   76.71%   76.74%   +0.02%     
==========================================
  Files         996      996              
  Lines       53080    53158      +78     
  Branches     6739     6763      +24     
==========================================
+ Hits        40721    40796      +75     
- Misses      12130    12132       +2     
- Partials      229      230       +1

Flag	Coverage Δ
javascript	`71.03% <64.63%> (+0.06%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Form/Form.tsx	`100.00% <ø> (ø)`
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx	`46.42% <ø> (-0.94%)`	⬇️
...rontend/src/explore/components/optionRenderers.tsx	`100.00% <ø> (ø)`
...set-frontend/src/views/CRUD/data/database/types.ts	`100.00% <ø> (ø)`
...c/visualizations/TimeTable/TimeTableChartPlugin.js	`75.00% <ø> (ø)`
superset/examples/bart_lines.py	`27.58% <0.00%> (ø)`
superset/examples/deck.py	`12.50% <0.00%> (ø)`
superset/examples/flights.py	`17.64% <0.00%> (ø)`
superset/examples/long_lat.py	`23.80% <0.00%> (ø)`
superset/examples/sf_population_polygons.py	`26.92% <0.00%> (ø)`
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61c34f...ef33f65. Read the comment docs.

junlincc · 2021-08-12T17:52:52Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true

github-actions · 2021-08-12T17:54:38Z

@junlincc Ephemeral environment spinning up at http://54.201.91.128:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

kgabryje · 2021-08-13T07:24:27Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true

github-actions · 2021-08-13T07:28:46Z

@kgabryje Ephemeral environment spinning up at http://18.237.98.47:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions · 2021-08-13T08:02:59Z

Ephemeral environment shutdown and build artifacts deleted.

…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)

rosemarie-chiu · 2021-08-13T21:40:30Z

🏷 2021.31

…clicked (#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)

…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py

…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)

…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 517a678)

…clicked (apache#16233) * fix(dashboard): cross filter chart highlight when filters badge icon pressed * Fix tests * Fix tests * break out label logic Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit 9f07295)

fix(dashboard): cross filter chart highlight when filters badge icon …

8ab0f21

…pressed

kgabryje requested review from simcha90, suddjian and villebro August 12, 2021 14:50

pull-request-size Bot added the size/M label Aug 12, 2021

kgabryje added 2 commits August 12, 2021 17:39

Fix tests

87f3462

Fix tests

388ac55

break out label logic

ef33f65

villebro approved these changes Aug 13, 2021

View reviewed changes

kgabryje merged commit 517a678 into apache:master Aug 13, 2021

superset-github-bot Bot added the preset:2021.31 label Aug 13, 2021

villebro added the v1.3 label Aug 16, 2021

mistercrunch added 🍒 1.3.0 Cherry-picked to 1.3.0 🍒 1.3.1 Cherry-picked to 1.3.1 🍒 1.3.2 Cherry-picked to 1.3.2 labels Mar 13, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 First shipped in 1.4.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dashboard): cross filter chart highlight when filters badge icon clicked#16233

fix(dashboard): cross filter chart highlight when filters badge icon clicked#16233
kgabryje merged 4 commits intoapache:masterfrom
kgabryje:fix/cross-filter-indicator

kgabryje commented Aug 12, 2021

Uh oh!

codecov Bot commented Aug 12, 2021 •

edited

Loading

Uh oh!

junlincc commented Aug 12, 2021

Uh oh!

github-actions Bot commented Aug 12, 2021

Uh oh!

kgabryje commented Aug 13, 2021

Uh oh!

github-actions Bot commented Aug 13, 2021

Uh oh!

github-actions Bot commented Aug 13, 2021

Uh oh!

rosemarie-chiu commented Aug 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kgabryje commented Aug 12, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codecov Bot commented Aug 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

junlincc commented Aug 12, 2021

Uh oh!

github-actions Bot commented Aug 12, 2021

Uh oh!

kgabryje commented Aug 13, 2021

Uh oh!

github-actions Bot commented Aug 13, 2021

Uh oh!

github-actions Bot commented Aug 13, 2021

Uh oh!

rosemarie-chiu commented Aug 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Aug 12, 2021 •

edited

Loading