feat: call screenshot to store query_context

[betodealmeida]

SUMMARY

#15830 modified the _get_csv_data functionality in the reports executor to use a new chart API introduced in #15827. One problem is that the new API can only be called for charts that were saved with their query_context, a change that was introduced in #15824.

Pre-existing charts have query_context set to null, so we can't use the new API with them. As a workaround, @hughhhh implemented logic to save query_context when a chart that doesn't have it saved is loaded (#15865). This PR leverages that work by taking a screenshot of the chart using Selenium whenever we need to call the CSV API but query_context is null.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

1. Create a chart, save.
2. Delete query_context of the chart (UPDATE slices SET query_context = NULL WHERE id=XXX)
3. Create a CSV report based on the chart
4. Report with CSV should arrive correctly, and query_context should be back.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #15846 (1a2d399) into master (62550db) will decrease coverage by 0.29%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##           master   #15846      +/-   ##
==========================================
- Coverage   77.05%   76.76%   -0.30%     
==========================================
  Files         986      986              
  Lines       51944    51993      +49     
  Branches     7081     7090       +9     
==========================================
- Hits        40025    39911     -114     
- Misses      11693    11856     +163     
  Partials      226      226              

Flag	Coverage Δ
hive	?
javascript	71.69% <11.11%> (-0.10%)	⬇️
mysql	81.39% <75.00%> (-0.05%)	⬇️
postgres	81.42% <75.00%> (-0.05%)	⬇️
presto	?
python	81.51% <75.00%> (-0.48%)	⬇️
sqlite	81.05% <75.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ntend/src/explore/components/ExploreChartPanel.jsx	15.00% <0.00%> (-1.67%)	⬇️
superset/models/slice.py	86.18% <ø> (ø)
superset/reports/commands/execute.py	92.17% <75.00%> (-0.72%)	⬇️
...d/src/explore/components/PropertiesModal/index.tsx	81.94% <100.00%> (+1.68%)	⬆️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.80% <0.00%> (-16.87%)	⬇️
superset/db_engine_specs/presto.py	83.47% <0.00%> (-6.49%)	⬇️
...-frontend/src/dashboard/reducers/dashboardState.js	66.66% <0.00%> (-4.31%)	⬇️
...perset-frontend/src/addSlice/AddSliceContainer.tsx	78.12% <0.00%> (-3.93%)	⬇️
.../src/explore/components/ControlPanelsContainer.tsx	76.02% <0.00%> (-3.00%)	⬇️
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62550db...1a2d399. Read the comment docs.

[eschutho]

do you think there may be a case where the screenshot finishes before the put? Do we need some error handling for that case?

[betodealmeida]

Good point, I'll add some error handling.

[eschutho]

Looks good, just left one small comment/question.