You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is just the tip of the iceberg. allow_csv_upload is almost everywhere in codebase including the database. Not sure the effects of renaming that. If someone can assist me in creating a db migration I can also do that.
ADDITIONAL INFORMATION
Requires DB Migration.
Confirm DB Migration upgrade and downgrade tested.
cemremengu
changed the title
refactor: rename methods with "csv" to "file"
refactor: replace "csv" with "file" used in common (excel) upload cases
Mar 26, 2021
cemremengu
changed the title
refactor: replace "csv" with "file" used in common (excel) upload cases
WIP: refactor: replace "csv" with "file" used in common (excel) upload cases
Mar 26, 2021
cemremengu
changed the title
WIP: refactor: replace "csv" with "file" used in common (excel) upload cases
[WIP] refactor: replace "csv" with "file" used in common (excel) upload cases
Mar 26, 2021
Merging #13805 (73e8901) into master (e61f5a9) will decrease coverage by 0.14%.
The diff coverage is 77.77%.
❗ Current head 73e8901 differs from pull request most recent head d64d701. Consider uploading reports for the commit d64d701 to get more accurate results
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just the tip of the iceberg.
allow_csv_uploadis almost everywhere in codebase including the database. Not sure the effects of renaming that. If someone can assist me in creating a db migration I can also do that.ADDITIONAL INFORMATION