Skip to content

[codex] Upgrade thrift to 0.23.0 and Go to 1.25#160

Open
HTHou wants to merge 1 commit into
mainfrom
codex/upgrade-thrift-0-23-0
Open

[codex] Upgrade thrift to 0.23.0 and Go to 1.25#160
HTHou wants to merge 1 commit into
mainfrom
codex/upgrade-thrift-0-23-0

Conversation

@HTHou
Copy link
Copy Markdown
Contributor

@HTHou HTHou commented May 12, 2026

Summary

  • upgrade github.com/apache/thrift from v0.15.0 to v0.23.0
  • raise the project Go directive, CI matrix, docs, and e2e client Docker image to Go 1.25
  • refresh README and binary license references for the new thrift version

Why Go 1.25

github.com/apache/thrift v0.23.0 declares go 1.25 in its module metadata, so modern Go tooling requires downstream modules to use Go 1.25 or newer. Older toolchains reject the dependency before build begins with:

github.com/apache/thrift@v0.23.0 requires go >= 1.25

The thrift runtime also uses newer Go features, including generics and standard-library packages such as log/slog, maps, and slices, so keeping the previous Go 1.13 baseline is no longer viable.

Validation

  • go mod download
  • make generate
  • make test
  • go list ./... | rg -v '/test/e2e$' | xargs go test
  • GitHub Actions: Go matrix and E2E Tests passed on this PR

@HTHou HTHou marked this pull request as ready for review May 12, 2026 03:41
@HTHou HTHou changed the title [codex] Upgrade thrift to 0.23.0 [codex] Upgrade thrift to 0.23.0 and Go to 1.25 May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant