[client] Implement BatchScanner with limit-based scan#515
Conversation
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@Arnav-panjla Ty for the PR, left some comments, PTAL
| "rustc_version", | ||
| ] | ||
|
|
||
| [[package]] |
There was a problem hiding this comment.
let's sync Cargo.lock in a separate PR, otherwise it's weird.
Want to pick this up?
| @@ -0,0 +1,254 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
We don't have any tests, do you mind to add unit and integration tests?
| Ok(self | ||
| .batch | ||
| .take() | ||
| .map(|b| ScanBatch::new(self.bucket.clone(), b, 0))) |
There was a problem hiding this comment.
why do we hardcode 0 here?
|
@Arnav-panjla Do you need any help, will you be able to address comments in the review? |
|
@Arnav-panjla Let us know if you wish to continue working on this PR, or we can take it over to finish |
|
very sry , |
@Arnav-panjla No rush, I just need to understand that you wish to continue working on this. |
2 participants
Purpose
Fixes #316
Implement one-shot
BatchScannerusingLimitScanRequest.Brief change log
limittoTableScancreate_batch_scannerBatchScanner(eager RPC, singlepoll_batch)RecordBatch(PK) decodingTests
cargo test)cargo check,clippy,fmtAPI and Format
API Change: Yes
BatchScanner,TableScan::limit,create_batch_scannerStorage Format: No
Documentation
No