Change disk-only VM snapshot removal message#11182
Change disk-only VM snapshot removal message#11182JoaoJandre wants to merge 2 commits intoapache:4.22from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #11182 +/- ##
============================================
+ Coverage 17.68% 18.09% +0.40%
- Complexity 15792 16721 +929
============================================
Files 5922 6037 +115
Lines 533087 542551 +9464
Branches 65206 66432 +1226
============================================
+ Hits 94269 98159 +3890
- Misses 428176 433373 +5197
- Partials 10642 11019 +377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16611 |
|
Looks like there is some caching issue
In a incognito window, try to delete the vm snapshots ,we get the same error message Screen.Recording.2026-01-29.at.6.22.56.PM.movScreen.Recording.2026-01-29.at.6.20.22.PM.mov |
|
@kiranchavala I think there might've been an issue with the version that I was basing this PR on. I have merged the main branch on my branch and tested and it looks good. Could you test again? |
|
@JoaoJandre |
Yes, both. I'll target 4.22 |
boring-cyborg
Bot
added
component:quota
component:saml
component:secondary-storage
component:security-group
component:security
component:simulator
component:solidfire
component:ssvm
component:storage
component:usage-server
component:virtual-router
component:vmware
component:vpc
component:vxlan
JoaoJandre
force-pushed
the
change-gui-message
branch
from
43e3805 to
f918513
Compare
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17765 |
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
@JoaoJandre i am observing the same behaviour
-
Launch 2 vm
-
Take a vm snapshot (Disk) of vm 1
-
Take a vm snapshot (Disk and Memory) of vm 2
-
Navigate to compute > Instance Snapshots > Delete snapshot 2
Error message
- Delete snapshot 1
Same Error messaage
|
@JoaoJandre I've noticed the other way in my testing, could see the same message for both types. 
|
6 participants
Description
This PR changes the warning given to users when deleting disk-only VM snapshots on KVM. When deleting disk-only VM snapshots on KVM, the VM is not paused.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
When deleting Disk-only VM snapshot:
When deleting Disk And Memory VM snapshot:
How Has This Been Tested?
Created two VM snapshots, one with and one without memory. I checked that the messages were being shown accordingly.