new network offering for VPC tier does not have any supported services

[weizhouapache]

when I create network offering for vpc tiers, I checked some services (dhcp,dns,sourcenat,staticnat,etc), the offering was created successfully.
however, the offering does not have any supported services. ntwk_offering_service_map does not contain any record.

in API log, supportedservices is empty.

2022-01-07 07:44:34,442 DEBUG [c.c.a.ApiServlet] (qtp1748876332-2873:ctx-66612acb) (logid:6edc4a9d) ===START=== 10.0.3.151 -- GET name=vpc-tier-no-userdata&displaytext=vpc-tier-no-userdata&guestiptype=isolated&enable=true&serviceofferingid=af59632a-b77b-4ae9-99a2-107a6ef1f5a0&sourcenattype=peraccount&forvpc=true&conservemode=false&supportedservices=&traffictype=GUEST&command=createNetworkOffering&response=json

this seems to be a regression of #5809, reverting #5809 fixes the issue.

ISSUE TYPE

• Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

4.16 and main

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

[weizhouapache]

@shwstppr
could you please have a look at this issue ?

[shwstppr]

@weizhouapache will look into it

[weizhouapache]

add vpc offering fails with error Request Failed (431) Empty or null value provided for API arg: supportedservices

[yadvr]

Fixed in #5840