fix: write error for dbg output of out of range timestamps#10130
Open
Jefffrey wants to merge 3 commits into
Open
fix: write error for dbg output of out of range timestamps#10130Jefffrey wants to merge 3 commits into
Jefffrey wants to merge 3 commits into
Conversation
Jefffrey
commented
Jun 12, 2026
| None => write!(f, "null"), | ||
| None => write!( | ||
| f, | ||
| "Cast error: Failed to convert {v} to timestamp for {data_type}" |
Contributor
Author
There was a problem hiding this comment.
same error message format as date & time branches above
Jefffrey
commented
Jun 12, 2026
| } | ||
|
|
||
| #[test] | ||
| fn test_timestamp_micros_out_of_range() { |
Contributor
Author
There was a problem hiding this comment.
consolidated this into newly added test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Confusing to print
nullwhen the value is not formattable via chrono, so instead clearly write an error.What changes are included in this PR?
Instead of writing
nullin debug output of timestamp arrays for values that exceed chronos range, write an error message for that row similar to date/time typesAre these changes tested?
Yes.
Are there any user-facing changes?
Not really.