fix: use Dag form when materializing asset#64211
Merged
bbovenzi merged 7 commits intoapache:mainfrom Mar 30, 2026
Merged
Conversation
Lee-W
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:API
bbovenzi
reviewed
Mar 25, 2026
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
reviewed
Mar 25, 2026
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
use-Dag-form-when-triggering-asset-materialization
branch
from
4c3b2f7 to
abaac1a
Compare
1 task
Lee-W
force-pushed
the
use-Dag-form-when-triggering-asset-materialization
branch
2 times, most recently
from
3f63ffd to
d2a9c8c
Compare
Lee-W
force-pushed
the
use-Dag-form-when-triggering-asset-materialization
branch
from
d2a9c8c to
52679e8
Compare
jason810496
reviewed
Mar 27, 2026
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py
Show resolved
Hide resolved
Lee-W
force-pushed
the
use-Dag-form-when-triggering-asset-materialization
branch
3 times, most recently
from
304a540 to
7c02681
Compare
Lee-W
force-pushed
the
use-Dag-form-when-triggering-asset-materialization
branch
from
7c02681 to
288ae68
Compare
Lee-W
force-pushed
the
use-Dag-form-when-triggering-asset-materialization
branch
from
288ae68 to
62b00b9
Compare
TriggerDAGForm no longer owns the trigger mutation after the refactor (onSubmitTrigger was made a prop). TriggerDAGModal must now supply useTrigger and pass error/isPending/onSubmitTrigger down to the form, otherwise clicking Trigger does nothing and dagRunId stays null.
Member
Author
|
chatted with @pierrejeambrun . let's move it to 3.2.1 |
bbovenzi
approved these changes
Mar 30, 2026
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Apr 3, 2026
* fix: use Dag form when materializing asset * fixup! fix: use Dag form when materializing asset * fixup! fixup! fix: use Dag form when materializing asset * fixup! fixup! fixup! fix: use Dag form when materializing asset * fixup! fixup! fixup! fixup! fix: use Dag form when materializing asset * test: add test case test_should_respond_200_with_trigger_fields_without_dag_run_id * fix: restore useTrigger in TriggerDAGModal after TriggerDAGForm refactor TriggerDAGForm no longer owns the trigger mutation after the refactor (onSubmitTrigger was made a prop). TriggerDAGModal must now supply useTrigger and pass error/isPending/onSubmitTrigger down to the form, otherwise clicking Trigger does nothing and dagRunId stays null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes: #63807
What
Use Dag from when materializing the asset
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.