Skip to content

Fix duplicate rules on init firewall#56621

Open
respawned86 wants to merge 1 commit intoanthropics:mainfrom
respawned86:fix/duplicate_rules_on_init_firewall
Open

Fix duplicate rules on init firewall#56621
respawned86 wants to merge 1 commit intoanthropics:mainfrom
respawned86:fix/duplicate_rules_on_init_firewall

Conversation

@respawned86
Copy link
Copy Markdown

📄 Description

Setting duplicate firewall rules will make the init-firewall.sh script fail.

The changes make sure to check whether the rule already exists before adding it.

🧪 Testing Guidelines

Clone the claude-code repository.
Open the folder in VS Code.
Wait for it to detect the Dev Container configuration.
Select "Reopen in Container"
Wait for the init-firewall.sh script to fail.

💡 Additional Info

This is the error modal that appears when the script fails.
image

These are some log lines of the error:

[6443 ms] postStartCommand from devcontainer.json failed with exit code 1. Skipping any further user-provided commands.
[6446 ms] Error: Command failed: /bin/sh -c sudo /usr/local/bin/init-firewall.sh

Setting duplicate firewall rules will make the init-firewall.sh script
fail.

The changes make sure to check whether the rule already exists before
adding it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants