fix(app): require query functions for sync queries#25939
Merged
Hona merged 2 commits intoanomalyco:devfrom May 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the app’s global-sync query helpers so sync-related queries always have real query functions, while lightweight loading checks use explicit query-key helpers instead of skipToken observers. It mainly touches bootstrap/query wiring in the app’s shared sync layer and the UI components that consume those query keys.
Changes:
- Reworked global-sync query helpers to require SDK clients and added explicit key helpers for session/MCP/LSP cache lookups.
- Moved some bootstrap-side store updates to
.then(...)handlers so cached query results can still hydrate app state. - Updated UI consumers (
sidebar-workspace, MCP dialogs/status, prompt input) to use the new query/key helpers.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/app/src/pages/layout/sidebar-workspace.tsx |
Replaces session loading observer usage with useIsFetching + session query-key helper. |
packages/app/src/context/global-sync/bootstrap.ts |
Refactors bootstrap query helpers to require SDK-backed query functions and moves some state hydration out of query fns. |
packages/app/src/context/global-sync.tsx |
Adds explicit query-key helpers and updates global sync bootstrap/session loading logic to use them. |
packages/app/src/components/status-popover-body.tsx |
Switches MCP refetching to use the explicit MCP query-key helper. |
packages/app/src/components/prompt-input.tsx |
Passes explicit SDK clients into provider/agent queries. |
packages/app/src/components/dialog-select-mcp.tsx |
Switches MCP refetching to use the explicit MCP query-key helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
66 tasks
oleksii-honchar
pushed a commit
to oleksii-honchar/better-opencode
that referenced
this pull request
May 6, 2026
thdxr
pushed a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipTokenobserversTesting
bun --conditions=browser -e "<paused providers query repro>"bun typecheckfrompackages/appbun turbo typecheck