refactor(cli/github+run): Stage 4 — drop AppRuntime.runPromise bridges#25539
Merged
kitlangton merged 1 commit intodevfrom May 3, 2026
Merged
refactor(cli/github+run): Stage 4 — drop AppRuntime.runPromise bridges#25539kitlangton merged 1 commit intodevfrom
kitlangton merged 1 commit intodevfrom
Conversation
3 tasks
github.ts: yield Git/Session/SessionShare/SessionPrompt/ModelsDev once at the top of each handler; replace inline AppRuntime.runPromise(Service.use(...)) calls with Effect.runPromise on the in-scope service. run.ts: same pattern for the single Agent.Service.get site. Drop the now-unused AppRuntime imports.
kitlangton
force-pushed
the
kit/cli-flatten-run-github
branch
from
86c4438 to
e64d3ac
Compare
oleksii-honchar
pushed a commit
to oleksii-honchar/better-opencode
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the Stage 4 cleanup arc — drops the remaining inline
AppRuntime.runPromise(Service.use(...))bridges incli/cmd/github.tsandcli/cmd/run.ts.Git/Session/SessionShare/SessionPrompt/ModelsDevonce at the top of each handler; replace the 8 inlineAppRuntime.runPromise(...)sites withEffect.runPromise(svc.method(...))on the in-scope service.Agent.Service.getsite.AppRuntimeimports from both files.Pure refactor — services already had typed
R = Servicerequirements, just lifted them up one level so the runtime resolves them once instead of per-call. No behavior change.Test plan
bun run typecheckcleanbun run test test/cli/github-action.test.ts test/cli/github-remote.test.ts— 31 pass