fix(desktop): Model selection UI becoming blank#25220
Closed
Eric-Guo wants to merge 2 commits intoanomalyco:devfrom
Closed
fix(desktop): Model selection UI becoming blank#25220Eric-Guo wants to merge 2 commits intoanomalyco:devfrom
Eric-Guo wants to merge 2 commits intoanomalyco:devfrom
Conversation
…nomalyco#25077)" This reverts commit 908e281.
Changed child-store.ts so provider_ready, mcp_ready, and lsp_ready all mean “loaded,” not “loading.” Also wired provider query data back into projectStore.provider, so restoring readiness semantics does not break model selection. Changed use-providers.ts to use project providers when the project store actually has provider data, falling back to global providers only while project data is unavailable.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression where the desktop model selection dropdown could render blank by ensuring the per-project provider list is actually populated from the providers query before the UI switches to using it.
Changes:
- Update
useProviders()to prefer the project-scoped provider list only once it has non-emptyallentries. - Sync
providerQuery.datainto each child store’sproviderfield via a SolidcreateEffect.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/hooks/use-providers.ts | Avoids switching to the child store’s provider list until it’s populated, preventing an empty list from being shown. |
| packages/app/src/context/global-sync/child-store.ts | Adds an effect to write providerQuery.data into the child store so the project-scoped provider list is no longer stuck at its initial empty value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Replaced by #25236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fix #25222
Type of change
What does this PR do?
Original PR #25077 break the model select box
How did you verify your code works?
It works in my machine
Screenshots / recordings
Checklist