Skip to content

feat: add resource_requests for Burstable QoS support(When creating a sandbox, support creating according to the strategy of low request and high limit)#669

Open
gaochunhui wants to merge 2 commits intoalibaba:mainfrom
gaochunhui:feat/resource-requests
Open

feat: add resource_requests for Burstable QoS support(When creating a sandbox, support creating according to the strategy of low request and high limit)#669
gaochunhui wants to merge 2 commits intoalibaba:mainfrom
gaochunhui:feat/resource-requests

Conversation

@gaochunhui
Copy link
Copy Markdown

@gaochunhui gaochunhui commented Apr 8, 2026

Summary

feat: add resource_requests for Burstable QoS support
When creating a sandbox, support creating according to the strategy of low request and high limit

Testing

  • Not run (explain why)
  • [ √] Unit tests
  • Integration tests
  • [√ ] e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

Add optional resourceRequests field to allow requests < limits,
enabling Kubernetes Burstable QoS for better resource utilization.

- OpenAPI spec: add resourceRequests to CreateSandboxRequest
- SDK: Sandbox.create() accepts resource_requests param
- Server: extract and pass resource_requests through to providers
- Providers: use separate requests in V1ResourceRequirements
- Backward compatible: defaults to limits when omitted

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9689015d88

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread sdks/sandbox/python/src/opensandbox/sandbox.py Outdated
Comment thread server/opensandbox_server/services/k8s/kubernetes_service.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants