Skip to content

Attachment handling #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everlanes wants to merge 3 commits into
base: master-getAttachFiles
Choose a base branch
from
Open

Attachment handling #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7709eda
Fix _trailer bug
everlanes Aug 4, 2019
1f6a8d1
Attach multiple files
everlanes Aug 4, 2019
e08f688
Add `removeAttachments` function
everlanes Aug 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions pypdf/pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,21 +374,20 @@ def addAttachment(self, fname, fdata):
endobj

"""
embeddedFilesNamesDictionary = DictionaryObject()
embeddedFilesNamesDictionary.update({
NameObject("/Names"): ArrayObject(
[createStringObject(fname), filespec]
)
})
embeddedFilesDictionary = self._rootObject.setdefault(
NameObject("/Names"),
DictionaryObject())

embeddedFilesDictionary = DictionaryObject()
embeddedFilesDictionary.update({
NameObject("/EmbeddedFiles"): embeddedFilesNamesDictionary
})
# Update the root
self._rootObject.update({
NameObject("/Names"): embeddedFilesDictionary
})
embeddedFilesNamesDictionary = embeddedFilesDictionary.setdefault(
NameObject("/EmbeddedFiles"),
DictionaryObject())

embeddedFilesList = embeddedFilesNamesDictionary.setdefault(
NameObject("/Names"),
ArrayObject())

embeddedFilesList.append(createStringObject(fname))
embeddedFilesList.append(filespec)

def appendPagesFromReader(self, reader, afterPageAppend=None):
"""
Expand Down Expand Up @@ -1007,6 +1006,15 @@ def removeText(self, ignoreByteStringObject=False):

pageRef.__setitem__(NameObject('/Contents'), content)

def removeAttachments(self):
"""
removes attachments from this output.

"""
embeddedFilesDictionary = self._rootObject.get("/Names", {})
embeddedFilesDictionary.update({
NameObject("/EmbeddedFiles"): DictionaryObject()})

def addURI(self, pagenum, uri, rect, border=None):
"""
Add an URI from a rectangular area to the specified page. This uses the
Expand Down Expand Up @@ -2682,7 +2690,7 @@ def getAttachFiles(self):
:rtype: list
"""
res = []
catalog = self.trailer['/Root']
catalog = self._trailer['/Root']
# get the name tree
catalog_name = self._get_dict_entry(catalog, '/Names')
if not catalog_name:
Expand Down