Skip to content

Add better support for command arguments#51

Draft
dolphinau wants to merge 4 commits intomainfrom
command_params
Draft

Add better support for command arguments#51
dolphinau wants to merge 4 commits intomainfrom
command_params

Conversation

@dolphinau
Copy link
Copy Markdown
Member

@dolphinau dolphinau commented May 5, 2026

Fix #48 #50

Currently, we have a low command argument support that miss some potential code execution done in parenthese expression or braced expression
This PR aims to improve support by handling

  • Variables and braced variables in command arguments
  • Parenthesis experession
  • Braced expression

I didn't add the auto generated files one purpose yet because the PR is not ready

WIP:

  • Added scanner to add concat support for variables in args
  • Added support for command arg names/value with potential ":" separtor
    • Does is work also with a " " separator?
    • Fix support for -argname:value and assert that value can be expendable
  • Add parenthesis/braced experession
    • Fix issue with toto(toto)toto that doesn't properly parse the last toto because there is no " " separtor between parenthesis expression and standard expression
  • Fix tests

@dolphinau dolphinau marked this pull request as draft May 5, 2026 14:09
@dolphinau dolphinau requested a review from citronneur May 5, 2026 14:12
@dolphinau dolphinau self-assigned this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable followed by parenthesized expression incorrectly parsed as argument_list in command elements

1 participant