fixes to verticalMetrics proofs#5
Merged
Merged
Conversation
in large-UPM fonts, the labels were tiny
the font in question had "uni0048" instead of "H", etc.
… so it’s easier to compare fonts from different UPM-worlds
frankrolf
requested review from
josh-hadley,
kaydeearts,
misbatabassum and
punchcutter
Member
Author
|
FWIW, not everyone has to review this – just thought you might be interested :-) |
josh-hadley
approved these changes
Aug 30, 2023
josh-hadley
left a comment
josh-hadley
left a comment
Contributor
There was a problem hiding this comment.
One suggestion; otherwise looks good. Nice to move more stuff to common modules!
Although verticalMetricsComparisonProof is dependent on verticalMetricsProof, it’s better to be explicit with the imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly about the labels in the vertical metrics proofs:
Along the way, I fixed some more issues I encountered:
H)Cosmetics: