Update verticalMetricsProof.py#2
Merged
Merged
Conversation
Quick-and-dirty fix to give winAscent/sTypoAscender/hhea.ascent labels a bit more breathing room at the top. At some point we should figure out a reliable calculation that takes overall (actual) tont height, label position, etc. into account so everything fits for every case.
frankrolf
approved these changes
Jun 22, 2023
frankrolf
left a comment
frankrolf
left a comment
Member
There was a problem hiding this comment.
Ha, just before the repo was made public, I had changed that line to
page_height = font_height * 1.5 * scale_factor
I agree more breathing room is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick-and-dirty fix to give winAscent/sTypoAscender/hhea.ascent labels a bit more breathing room at the top. At some point we should figure out a reliable calculation that takes overall (actual) tont height, label position, etc. into account so everything fits for every case.