Skip to content

add kerning toggle (-k)#11

Merged
frankrolf merged 1 commit into
mainfrom
kerning_toggle
May 7, 2024
Merged

add kerning toggle (-k)#11
frankrolf merged 1 commit into
mainfrom
kerning_toggle

Conversation

@frankrolf

Copy link
Copy Markdown
Member

addresses #6

@frankrolf

Copy link
Copy Markdown
Member Author

I implemented your suggestion @benkiel, if you have time to check out the result I’d be grateful :-)

@frankrolf frankrolf requested a review from benkiel March 14, 2024 11:36
@frankrolf

Copy link
Copy Markdown
Member Author

Did you get a moment to review this @benkiel, or should I just merge it?

@benkiel

benkiel commented May 7, 2024

Copy link
Copy Markdown
Collaborator

Yes, this works well! I would suggest that the toggle be -nk, as -k implies that kerning is on, but the nice output note on the pdf helps here

@frankrolf frankrolf merged commit 7cb0823 into main May 7, 2024
@frankrolf frankrolf deleted the kerning_toggle branch May 7, 2024 20:46
@frankrolf

frankrolf commented May 7, 2024

Copy link
Copy Markdown
Member Author

Thanks for taking a look!

I understand that the single-letter options may be ambiguous, however this also makes it possible to chain them.

For when you need to be explicit, there’s always the --kerning_off option:
https://github.com/adobe-type-tools/drawBotProofing/blob/main/textProof.py#L110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants