Stop binding glyph metrics callbacks to the first GlyphMetrics instance#1841
Open
caolanm wants to merge 1 commit into
Open
Stop binding glyph metrics callbacks to the first GlyphMetrics instance#1841caolanm wants to merge 1 commit into
caolanm wants to merge 1 commit into
Conversation
The function-local static in processGlyphs captures "this" once, so a second conversion in the same process runs the glyph callbacks against the first, already-deleted instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function-local static in processGlyphs captures "this" once, so a second conversion in the same process runs the glyph callbacks against the first, already-deleted instance.
Description
seen in a debugging build that issues arise on reusing a this beyond its lifetime
Checklist: