[WP.7.0] Admin UI: Backport accessibility fixes (#77617, #78001)#78002
Open
[WP.7.0] Admin UI: Backport accessibility fixes (#77617, #78001)#78002
Conversation
t-hamano
changed the title
t-hamano
added
[Type] Bug
This was referenced May 6, 2026
|
Size Change: -13 B (0%) Total Size: 7.61 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
admin-ui-a11y-heading-wp7.0
branch
from
5f9e3a6 to
0271a0f
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-project-automation
Bot
moved this to 🔎 Needs Review
in WordPress 7.0 Editor Tasks
* admin-ui: Change default heading level to 1 in Page Header * Update CHANGELOG.md * Update all pages * Remove heading level from experimental Dashboard * edit-site: Explicitly set headingLevel=2 for Page components in site editor These Page components are rendered inside nested landmark regions within the site editor layout, where h2 is the semantically correct heading level. They were relying on the old default of 2 which changed to 1. Co-authored-by: simison <simison@git.wordpress.org> Co-authored-by: retrofox <retrofox@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
The Page header was rendered as a `<header>` element nested inside NavigableRegion's `role="region"` wrapper. Because `role="region"` is not an HTML sectioning element, the inner `<header>` retained its implicit `banner` role, producing a banner landmark nested inside a region landmark. Drop the `<header>` element so the wrapping region remains the sole landmark for the page surface.
t-hamano
force-pushed
the
admin-ui-a11y-heading-wp7.0
branch
from
0271a0f to
243156c
Compare
|
Flaky tests detected in 243156c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25433345175
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Backport #77617 and #78001 to the
wp/7.0branch.headingLevelof the Admin UIPageheader fromh2toh1.<header>element from the Admin UIPageheader so it no longer creates abannerlandmark nested inside the wrappingregion.Why?
The problems first became apparent in WP 7.0 and should be fixed. However, we cannot directly cherry-pick the two PRs into
WP/7.0because the structure of admin-ui has diverged slightly.How?
Cherry-pick from
trunkand adapt towp/7.0:Testing Instructions
#77617
Verify the heading level on the affected screens listed in the original PR description:
connectors-home,font-list) render ash1.navigation-list,navigation-edit,pattern-list,post-list,styles,template-part-list) render ash2.#78001
On any page using
Page(e.g. Settings → Connectors), open the DevTools Accessibility pane and confirm there is nobannerlandmark nested inside the page'sregionlandmark.Screenshots or screencast
N/A — no visual changes.