Conversation
| import * as EmptyState from '../'; | ||
|
|
||
| const meta: Meta< typeof EmptyState.Root > = { | ||
| tags: [ 'manifest' ], |
There was a problem hiding this comment.
@retrofox Per #77765 (comment), I went ahead and added the tag here, as part of marking this "stable".
There was a problem hiding this comment.
Thanks for letting me know. I've just started addressing it.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 7a9eaa7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25402465006
|
| componentStatus: { | ||
| status: 'use-with-caution', | ||
| whereUsed: 'global', | ||
| notes: 'Not yet recommended for use in Gutenberg core, pending review of popover compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
Nit on the wording (here and everywhere else in the PR):
| notes: 'Not yet recommended for use in Gutenberg core, pending review of popover compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', | |
| notes: 'Not yet recommended for use in Gutenberg core, pending review of overlays compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
Good reminder, I'll try to use "overlay" consistently for this purpose.
| componentStatus: { | ||
| status: 'use-with-caution', | ||
| whereUsed: 'global', | ||
| notes: 'Not yet recommended for use in Gutenberg core, pending review of popover compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
Good reminder, I'll try to use "overlay" consistently for this purpose.
| componentStatus: { | ||
| status: 'stable', | ||
| whereUsed: 'global', | ||
| }, |
| component: Badge, | ||
| parameters: { | ||
| componentStatus: { | ||
| status: 'stable', |
There was a problem hiding this comment.
I've been wanting to change the word "stable" as is it doesn't apply to the @wordpress/ui package like it does to @wordpress/components. Can we change it (throughout the entire Storybook) to "recommended" or something?
| componentStatus: { | ||
| status: 'use-with-caution', | ||
| whereUsed: 'global', | ||
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, popover compatibility, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, popover compatibility, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', | |
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
| componentStatus: { | ||
| status: 'use-with-caution', | ||
| whereUsed: 'global', | ||
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, popover compatibility, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, popover compatibility, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', | |
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
| componentStatus: { | ||
| status: 'use-with-caution', | ||
| whereUsed: 'global', | ||
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, popover compatibility, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, popover compatibility, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', | |
| notes: 'Not yet recommended for use in Gutenberg core, pending review of style consistency with `@wordpress/components`, and component set completeness. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
| componentStatus: { | ||
| status: 'use-with-caution', | ||
| whereUsed: 'global', | ||
| notes: 'Not yet recommended for use in Gutenberg core, pending review of popover compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
There was a problem hiding this comment.
| notes: 'Not yet recommended for use in Gutenberg core, pending review of popover compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', | |
| notes: 'Not yet recommended for use alongside components from `@wordpress/components`, pending review of popover compatibility. See [WordPress/gutenberg#76135](https://github.com/WordPress/gutenberg/issues/76135).', |
Would it be confusing if we worded it something like this? To be precise, it's not a "Gutenberg core" problem but a "mixed use with @wordpress/components" problem.
What?
Related: #76135
Updates Storybook stories in
@wordpress/uito add status indicators introduced in #74815.Why?
To make it clearer which components are ready to use in Gutenberg, and what blockers remain for the components that are not ready yet.
Also serves as a good nudge to ourselves what remains before we can mark a component as stable, or even instances where there's no good reason for a component not to be stable already (e.g. "Icon").
This could also potentially allow us to surface some more nuance through the design system MCP (e.g. use X component for now, but Y component from
@wordpress/uiwill soon be available for use).How?
Add
componentStatusentry for each component story in@wordpress/ui:'stable'if already allowed via@wordpress/use-recommended-componentsallowlist'use-with-caution', cautioning use in Gutenberg with component-specific warnings based on blockers highlighted in Components: Add usage guidance for agents and Storybook #74815.Use
whereUsed: 'global'for every component, since all of these components are meant to be globally usable.Testing Instructions
Verify in Storybook:
npm run storybook:devReview the individual component status notes. Do they make sense? If you disagree with a component's status, do we have the actual blockers tracked anywhere?
Screenshots or screencast
Examples:
Stable:
Use with caution:
Use of AI Tools
Implemented using Claude Code and Opus 4.7, pre-prompted with logic described in "How?" and iterations on specific status notes.
cc @grbicsanja