Add lint rule for non-module stylesheet imports#77984
Merged
Conversation
github-actions
Bot
added
[Package] Editor
|
Size Change: +166 B (0%) Total Size: 7.95 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in e72da23. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25434276874
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
approved these changes
May 6, 2026
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Great fix! LGTM 🚀
so are bulk suppressed time for the time being.
Thank you for writing your PR descriptions by hand 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Part of #76744
Adds an ESLint rule to prevent new non-module stylesheet imports in JavaScript files.
Why?
Non-module stylesheet imports in JavaScript are easy to miss because they work at runtime, but they bypass the normal stylesheet pipeline. That can duplicate styles, omit styles from the enqueued stylesheet bundle, and skip build-time processing such as RTL generation.
How?
@wordpress/no-non-module-stylesheet-importswith tests and documentation.routes, with bulk suppressions for existing route/package cases that need separate migration.Testing Instructions
The stylesheet imports removed in this PR should be included in their respective stylesheet entry points. Other violations are less straightforward, so are bulk suppressed time for the time being.