RTC: Fix collaborator cursor rendering in table cells#77276
Open
karthikeya-io wants to merge 3 commits intoWordPress:trunkfrom
Open
RTC: Fix collaborator cursor rendering in table cells#77276karthikeya-io wants to merge 3 commits intoWordPress:trunkfrom
karthikeya-io wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #76812
This PR fixes an issue where collaborator cursors fail to render in Table block cells during a Real-Time Collaboration (RTC) session.
Why?
Y.Text -> attributes Y.Map -> block Y.Map. While this works for other blocks, Table text is buried much deeper (inside Rows and Cells). The original logic would stop too early, fail to find the block ID, and return null.How?
Updated the selection flow to handle deep nesting:
post-editor-awareness.tsreplaced the fixed 2-level check with a while loop. This loop walks up the data tree until it finds the block ID.data-wp-block-attribute-keyto the HTML so the cell can be identified.getYjsValueByPathto get the Y.Text object for that specific cell using the attributetKey likebody[0].cells[1].content.cursor-dom-utils.tsto use theattributeKey. Instead of searching the whole table, it now jumps directly to the specific cell element before counting characters.ResolvedSelectiontype and the selection resolver to include theattributeKey, ensuring the cell's address is passed correctly.Testing Instructions
Screenshots or screencast
Screen.Recording.2026-04-15.at.7.18.34.PM.mov
Screen.Recording.2026-04-15.at.7.08.32.PM.mov
Use of AI Tools
Drafted with Gemini assistance and reviewed it before submission