Drop gettext as no longer needed#342
Merged
Merged
Conversation
sarahec
force-pushed
the
fix-missing-gettext
branch
from
c2c1c49 to
07037ae
Compare
sarahec
changed the title
sarahec
changed the title
sarahec
force-pushed
the
fix-missing-gettext
branch
2 times, most recently
from
a0cb1b3 to
81a5b5c
Compare
sarahec
force-pushed
the
fix-missing-gettext
branch
from
96a4bb6 to
b5512b3
Compare
sarahec
changed the title
|
I just ran into this issue building ReadStat. Can this be reviewed? |
Contributor
Author
Apologies. I forgot it was a draft. |
|
All good, these things happen. |
evanmiller
reviewed
Nov 8, 2025
|
|
||
| # Don't forget to update these too | ||
| READSTAT_MAJOR_VERSION=1 | ||
| READSTAT_MAJOR_VERSION=1 |
Contributor
There was a problem hiding this comment.
Please remove these stray spaces
Contributor
Author
There was a problem hiding this comment.
Done. Thank you for catching this.
sarahec
force-pushed
the
fix-missing-gettext
branch
from
b5512b3 to
1d85f0f
Compare
This was referenced Apr 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens with gettext 0.25.
gettextis there to supplyiconvin older scripts.iconv()has been obsolete since 2001.Fixes #341