F2592 locale date time#37
Open
shewitt-au wants to merge 72 commits intoWerWolv:masterfrom
Open
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
===========================================
- Coverage 64.35% 51.97% -12.38%
===========================================
Files 16 18 +2
Lines 606 758 +152
Branches 102 133 +31
===========================================
+ Hits 390 394 +4
- Misses 184 321 +137
- Partials 32 43 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Needs cleaning up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
In ImHex Dates and times currently have a fixed format and do not respect the selected language. MinGW’s (Windows)
std::localeclass is broken and basically useless. This PR implements, along with the ImHex PR linked below, date and time formatting using the Win32 API on Windows and the C runtime library on other OSes.The motivating feature request can be found here:
Format time based on locale #2592
The corresponding ImHex changes and links to other dependant PRs can be found here:
ImHex changes
Implementation description
Three new files have been added: