fix(cli): add test and fix for argv readonly handling#2473
Open
Zenvila wants to merge 1 commit intoWerWolv:masterfrom
Open
fix(cli): add test and fix for argv readonly handling#2473Zenvila wants to merge 1 commit intoWerWolv:masterfrom
Zenvila wants to merge 1 commit intoWerWolv:masterfrom
Conversation
Author
|
Kindly review the request |
Contributor
|
Is there a reason this CLI flag was given its own parser instead of just being registered as a subcommand the same way every other CLI flag is handled? And unless I'm reading your PR wrong, you're implementing a whole new feature here (read-only mode), not just adding a test for an existing feature, so why is this marked as a test/fix instead of a feature? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a failing test for the
argvbug related to readonly handling in the CLI,and provides a fix to ensure proper argument parsing.
Changes
tests/cli/test_cli_readonly.cppto reproduce the bug.argv.Motivation
Previously, the CLI would incorrectly handle readonly cases with
argv,leading to unexpected behavior. This PR ensures that the issue is reproducible
via a test and then properly resolved in the code.
Testing
Related
Fixes #