Fix: translation repository browser by BrenABarn · Pull Request #19184 · WeblateOrg/weblate

BrenABarn · 2026-04-23T00:15:03Z

What this PR does

Adds a new optional "Repository browser for translations" field to the component settings. When set, this URL is used to generate links to translation files instead of the existing "Repository browser" field. If left empty, it falls back to the existing field, maintaining backward compatibility.

Changes

New repoweb_translations model field on Component
Database migration
Updated get_repoweb_link to accept is_translation parameter
Updated translation_file_link in edit view to use the new field
Documentation added for the new field
Tests added for the new behavior and fallback logic

codecov · 2026-04-23T06:25:42Z

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

nijel

Thanks for the pull request. Besides the bits I've commented inline, this needs to be exposed in the API and deserves a changelog entry.

I've also triggered copilot review now.

nijel · 2026-04-23T06:23:07Z

+You can use :ref:`markup`.
+
+For example on GitHub, use something like:
+``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``


I think it will break rendering without newline:

Suggested change

``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``

``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``

Also, the seealso should be present in both of thse.

nijel · 2026-04-23T06:25:07Z

+                    "1",
+                    is_translation=True,
+                    user=user,
+                )


This change removes support for direct https links.

nijel · 2026-04-23T06:27:49Z

This migration is not based on the current main:

Conflicting migrations detected; multiple leaf nodes in the migration graph: (0069_component_repoweb_translations, 0073_alter_change_action in trans).

Please rename it and adjust dependencies.

Copilot

Pull request overview

This PR adds support for a separate “repository browser” URL specifically for translation files, so the translation editor can link to a different repo than the source-string locations (fixing #12308).

Changes:

Adds a new Component.repoweb_translations field (with migration) and exposes it in component settings forms.
Extends Component.get_repoweb_link() with an is_translation flag to select the appropriate template (with fallback behavior) and adds tests for the new logic.
Documents the new setting in the admin documentation.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
weblate/trans/models/component.py	Adds `repoweb_translations` field and `is_translation` option in `get_repoweb_link()` template selection.
weblate/trans/migrations/0069_component_repoweb_translations.py	Adds DB field for `repoweb_translations`.
weblate/trans/forms.py	Exposes the new field in component settings UI.
weblate/trans/views/edit.py	Updates translation editor context to generate translation file links via `get_repoweb_link(..., is_translation=True)`.
docs/admin/projects.rst	Documents “Repository browser for translations”.
weblate/trans/tests/test_component.py	Adds tests validating selection and fallback logic for translation repoweb templates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-23T06:27:52Z

@@ -1813,7 +1826,9 @@ def get_repoweb_link(
        here.
        """


The docstring for get_repoweb_link now says it generates a link to the “source code browser”, but the new is_translation flag makes it generate translation file links as well. Update the docstring to reflect the broader behavior so callers understand when to use is_translation vs. the default.

Copilot · 2026-04-23T06:27:53Z

+You can use :ref:`markup`.
+
+For example on GitHub, use something like:
+``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``


RST directives generally need a blank line before them. Here .. seealso:: directly follows the example URL line, which can trigger Sphinx/reST warnings or mis-parsing. Add a blank line between the example and the .. seealso:: directive.

Suggested change

``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``

``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``

Copilot · 2026-04-23T06:27:53Z

+                unit.translation.component.get_repoweb_link(
+                    unit.translation.filename,
+                    # '1' as a placeholder, because `get_repoweb_link` can't currently
+                    # generate links without line specified. Although it's ok to use
+                    # '' or '0' on GitHub or GitLab, let's play it safe for now.
+                    "1",
+                    is_translation=True,
+                    user=user,
+                )


translation_file_link previously rendered as linkified HTML (via try_linkify_filename) with the filename as the visible text and support for user editor_link. It now returns a raw URL string from get_repoweb_link, which will be displayed as plain text (and not clickable) in translate.html and changes behavior for users with editor_link configured. Consider restoring the prior output shape (SafeString anchor with filename as label) while selecting the translation repoweb template (e.g., by extending the helper to support translation links or wrapping the generated URL in the same markup).

Suggested change

unit.translation.component.get_repoweb_link(

unit.translation.filename,

# '1' as a placeholder, because `get_repoweb_link` can't currently

# generate links without line specified. Although it's ok to use

# '' or '0' on GitHub or GitLab, let's play it safe for now.

"1",

is_translation=True,

user=user,

)

format_html('<a href="{}">{}</a>', translation_file_link, unit.translation.filename)

if (

translation_file_link := unit.translation.component.get_repoweb_link(

unit.translation.filename,

# '1' as a placeholder, because `get_repoweb_link` can't currently

# generate links without line specified. Although it's ok to use

# '' or '0' on GitHub or GitLab, let's play it safe for now.

"1",

is_translation=True,

user=user,

)

)

else format_html("{}", unit.translation.filename)

Copilot · 2026-04-23T06:27:53Z

        if not template:
-            if self.repoweb:
+            if is_translation and self.repoweb_translations:
+                template = self.repoweb_translations
+            elif self.repoweb:
                template = self.repoweb
            elif user and user.has_perm("vcs.view", self):


is_translation influences template selection here, but the method later delegates to linked_component.get_repoweb_link(...) without passing is_translation. If template is still falsy at delegation time (e.g., relying on the linked component’s settings), translation links will be generated using the linked component’s non-translation fallback. Ensure the delegation path preserves the is_translation intent so linked repositories can use repoweb_translations correctly.

for more information, see https://pre-commit.ci

BrenABarn added 3 commits April 22, 2026 19:07

Add separate repository browser URL for translation files

b92788a

Restore tesserocr import

7e54b1a

fix: add separate repository browser URL for translation files

d0b8058

BrenABarn requested a review from nijel as a code owner April 23, 2026 00:15

Merge branch 'main' into fix/translation-repoweb

b077ac0

BrenABarn changed the title ~~Fix/translation repoweb~~ Fix: translation repository browser Apr 23, 2026

nijel requested a review from Copilot April 23, 2026 06:22

Copilot started reviewing on behalf of nijel April 23, 2026 06:23 View session

nijel reviewed Apr 23, 2026

View reviewed changes

Copilot AI reviewed Apr 23, 2026

View reviewed changes

BrenABarn and others added 4 commits April 23, 2026 18:15

Merge branch 'main' into fix/translation-repoweb

8b992c2

updated migration file

2f90a06

fix: address review feedback on translation repoweb

d45be02

[pre-commit.ci] auto fixes from pre-commit.com hooks

2ae1b03

for more information, see https://pre-commit.ci

BrenABarn marked this pull request as draft April 24, 2026 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: translation repository browser#19184

Fix: translation repository browser#19184
BrenABarn wants to merge 8 commits intoWeblateOrg:mainfrom
BrenABarn:fix/translation-repoweb

BrenABarn commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026

Uh oh!

nijel left a comment

Uh oh!

nijel Apr 23, 2026

Uh oh!

nijel Apr 23, 2026

Uh oh!

nijel Apr 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Copilot AI Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``
	``https://github.com/WeblateOrg/translations/blob/{{branch}}/{{filename}}#L{{line}}``

Uh oh!

Conversation

BrenABarn commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026

⚠️ JUnit XML file not found

Uh oh!

nijel left a comment

Choose a reason for hiding this comment

Uh oh!

nijel Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

nijel Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

nijel Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants