Add a missing drop-readable call#786
Merged
Merged
Conversation
I'm not sure how to add a test for this so the fix here is just in isolation.
badeend
approved these changes
Apr 21, 2026
| __wasilibc_future_block_on(sockets_future_result_void_error_code_read( | ||
| state->receive_result, &result), | ||
| state->receive_result); | ||
| sockets_future_result_void_error_code_drop_readable(state->receive_result); |
Member
There was a problem hiding this comment.
Maybe also take a look at tcp_write_eof
dicej
approved these changes
Apr 21, 2026
Collaborator
Author
|
If this becomes too much of a problem in the future, too, I might take a look at enabling a mode of the CLI to assert that all handles are closed by the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how to add a test for this so the fix here is just in isolation.