Skip f32.wast on linux due to Alpine issue + add testing#8558
Merged
kripken merged 9 commits intoWebAssembly:mainfrom Apr 1, 2026
Merged
Skip f32.wast on linux due to Alpine issue + add testing#8558kripken merged 9 commits intoWebAssembly:mainfrom
kripken merged 9 commits intoWebAssembly:mainfrom
Conversation
Member
Author
|
Skipping the test is disabled atm to verify we error without it. |
kripken
changed the title
stevenfontanella
approved these changes
Mar 31, 2026
Member
stevenfontanella
left a comment
stevenfontanella
left a comment
There was a problem hiding this comment.
Will follow up and get it passing again
Member
|
If we can't easily find all of the tests that are broken, maybe just disable all of the ones from #8472? Or we can also run the CI once with fail fast disabled. |
Member
Author
|
Good idea about |
stevenfontanella
added a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was noticed during creating the 129 release: #8557 (comment)
Add an alpine build to CI for x86_64, mirroring our release builds, so we do
not lack coverage (which led to the issue only showing on release, not CI).
Also make the alpine CI build identical to alpine release (copied from
create_release).