build with GCC 15.x fails

[eworm-de]

Building Virtualbox with gcc 15.x fails with errors in include/iprt/types.h regarding type bool.

(I will provide logs/output later if you are interested.)

[eworm-de]

This is the compiler output:

In file included from /build/virtualbox/src/VirtualBox-7.1.8/src/VBox/Runtime/common/misc/sanity.h:38,
                 from /build/virtualbox/src/VirtualBox-7.1.8/src/VBox/Runtime/common/misc/sanity-c.c:37:
/build/virtualbox/src/VirtualBox-7.1.8/include/iprt/types.h:285:15: error: ‘bool’ cannot be defined via ‘typedef’
  285 | typedef _Bool bool;
      |               ^~~~
/build/virtualbox/src/VirtualBox-7.1.8/include/iprt/types.h:285:15: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
/build/virtualbox/src/VirtualBox-7.1.8/include/iprt/types.h:285:1: warning: useless type name in empty declaration
  285 | typedef _Bool bool;
      |

[Vamp898]

Building on GCC 15.1.0 works without issues for me.

[eworm-de]

Building on GCC 15.1.0 works without issues for me.

Hmm... 🤨 What OS and architecture is this?

[ceamac]

Building on GCC 15.1.0 works without issues for me.

It works because of this patch

I should send a few of them upstream, but I need to read more about that CLA first

[eworm-de]

Ah, that one... It works to build the Virtualbox binaries, but fails to build the modules. This is the patch I use for Arch Linux.

[eworm-de]

Should be fixed with 34b07da I guess...

[eworm-de]

Well, it is supposed to, build still fails to build:

/build/virtualbox/src/VirtualBox-7.1.12/include/iprt/types.h:255:103: error: missing binary operator before token ‘(’
  255 | #if (!defined(__cplusplus) || (defined(__IBMCPP__) && defined(RT_OS_OS2))) && !RT_STDC_VERSION_PREREQ(202311L)
      |                                                                                                      ^

[Vamp898]

I'm no C expert but this looks like the code simply is wrong. The parentheses don't seem to match.

There are 3 ))) at the end of OS2, there should only be 2 if I counted right

// edit i counted wrongly :D forget my comment. And of course would GCC have complained about that first... It's time to go to bed

//Edit2 before I'm going, I let this here for you to try

#if (!defined(__cplusplus) || (defined(__IBMCPP__) && defined(RT_OS_OS2))) && !(RT_STDC_VERSION_PREREQ(202311L))

The parentheses could help

[eworm-de]

The parentheses could help

They don't.

[Vamp898]

That's a bummer, in that case we have to wait for someone with real knowledge^^ sorry for that.

[eworm-de]

Oh, guess we need 0528497 on top? Let me check...

[eworm-de]

Does not apply to 7.1.x... 😒

[eworm-de]

I can confirm that building with a9156b2, 34b07da & 0528497 succeeds. Thanks!