main: report: Handle nullptr const char ptr in Report::Text again#116
Merged
Conversation
In 9f10c00 main: report: remove custom DList, updates the `Report::Text` function was switched to accept `std::string&` instead of `const char*`. In the conversion the possibility of the char ptr to be a nullptr was forgotten. A nullptr for text is interpreted as `draw_a_line`. As `std::string` has no distinction between nullptr and an empty string introduce the variable `bool draw_a_line` and reintroduce the `const char*` overloads for `Report::Text` and `ReportEntry()`. Add tests to check ReportEntry constructors with `const char *` and `std::string`. Especially the new behavior when `nullptr` is passed as text, which should be the only instance `draw_a_line` should be set to true. fixes: #115
Contributor
Author
|
screenshots of the fixed tables
|
Member
|
Excellent fix and explanation !! Much Appreciation and Gratitude to you, NeroBurner !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 9f10c00 main: report: remove custom DList, updates
the
Report::Textfunction was switched to acceptstd::string&insteadof
const char*. In the conversion the possibility of the char ptr tobe a nullptr was forgotten. A nullptr for text is interpreted as
draw_a_line. Asstd::stringhas no distinction between nullptr andan empty string introduce the variable
bool draw_a_lineandreintroduce the
const char*overloads forReport::TextandReportEntry().Add tests to check ReportEntry constructors with
const char *andstd::string. Especially the new behavior whennullptris passed astext, which should be the only instance
draw_a_lineshould be set totrue.
fixes: #115