Fix bug in DBML column default rendering with single quotes#45
Merged
Vanderhoof merged 1 commit intoNov 28, 2024
Merged
Conversation
- Integrated `prepare_text_for_dbml` into `default_to_str` for consistent handling of special characters in DBML column strings. - Updated the test suite to include a new test case for handling binary string input (`b'0'`).
Owner
|
Awesome, thanks a lot 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the DBML renderer where column default values containing single quotes (
') were rendered in a syntax-breaking format.Issue:
When rendering column defaults with single quotes, the output would generate invalid DBML syntax. For example:
Fix
The default_to_str function now uses the prepare_text_for_dbml utility to ensure that single quotes are properly escaped, resulting in valid DBML syntax. For example:
Changes