Skip to content

Skip video search results with invalid channel IDs#945

Merged
Tyrrrz merged 1 commit intoprimefrom
fix-ghost-video-search-results
Mar 25, 2026
Merged

Skip video search results with invalid channel IDs#945
Tyrrrz merged 1 commit intoprimefrom
fix-ghost-video-search-results

Conversation

@Tyrrrz
Copy link
Copy Markdown
Owner

@Tyrrrz Tyrrrz commented Mar 25, 2026

Closes #944

Copilot AI review requested due to automatic review settings March 25, 2026 12:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a crash in SearchClient when search results include video items with syntactically invalid channel IDs (e.g., "UC"), by validating/parsing the channel ID before constructing Author.

Changes:

  • Add ChannelId.TryParse() validation for videoData.ChannelId in search video results.
  • Skip video results whose channel ID cannot be parsed into a valid ChannelId.
  • Construct Author using the parsed ChannelId value instead of relying on implicit conversion.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread YoutubeExplode/Search/SearchClient.cs
Comment thread YoutubeExplode/Search/SearchClient.cs
@Tyrrrz Tyrrrz merged commit 933c8cb into prime Mar 25, 2026
11 checks passed
@Tyrrrz Tyrrrz deleted the fix-ghost-video-search-results branch March 25, 2026 12:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (76e7d56) to head (24f4591).
⚠️ Report is 1 commits behind head on prime.

Additional details and impacted files
@@     Coverage Diff      @@
##   prime   #945   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search results may contain videos with no author information

2 participants