Skip to content

Add polyfill for Path.Combine(params ...)#26

Merged
Tyrrrz merged 2 commits intomasterfrom
path-combine
Nov 15, 2025
Merged

Add polyfill for Path.Combine(params ...)#26
Tyrrrz merged 2 commits intomasterfrom
path-combine

Conversation

@Tyrrrz
Copy link
Copy Markdown
Owner

@Tyrrrz Tyrrrz commented Nov 15, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 15, 2025 14:55
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 15, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a polyfill for Path.Combine(params string[]) to enable the variadic overload of Path.Combine for projects targeting .NET Framework versions prior to .NET 4.0.

Key Changes:

  • Implements Path.Combine(params string[]) using LINQ's Aggregate method to successively combine paths
  • Uses conditional compilation to only apply the polyfill for NETFRAMEWORK && !NET40_OR_GREATER targets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PolyShim/NetCore10/Path.cs Outdated
Comment thread PolyShim/NetCore10/Path.cs Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tyrrrz Tyrrrz merged commit 34464d9 into master Nov 15, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the path-combine branch November 15, 2025 15:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (63b4718) to head (60ab459).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #26   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants