Add PowerKit; replace hand-rolled Box<T> with Cell<T>#27
Conversation
…Box to lastValueCell Agent-Logs-Url: https://github.com/Tyrrrz/Gress/sessions/66893970-eb79-4fe3-bb9f-01ff07aab45f Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
@copilot build fails |
There was a problem hiding this comment.
Pull request overview
This PR introduces PowerKit as a source-only (dev) dependency and replaces the project’s internal Box<T> helper with PowerKit’s Cell<T>, while also bumping PolyShim to the version required by PowerKit.
Changes:
- Add
PowerKit(dev-only) package reference and central package version. - Update
ProgressExtensionsto usePowerKit.Cell<T>instead ofGress.Utils.Box<T>. - Remove the now-redundant
Gress/Utils/Box.csimplementation and bumpPolyShimto2.9.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Directory.Packages.props | Adds PowerKit version and bumps PolyShim to align dependencies. |
| Gress/Gress.csproj | References PowerKit with PrivateAssets="all" to keep it non-transitive. |
| Gress/Utils/Box.cs | Deletes the hand-rolled container type now replaced by PowerKit. |
| Gress/ProgressExtensions.cs | Swaps Box<T> usage for Cell<T> and updates the using directive. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
….DBus.Protocol 0.21.3 Agent-Logs-Url: https://github.com/Tyrrrz/Gress/sessions/5b4b62ac-88dc-4538-b546-9929bc05c555 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Fixed in be5a1bc. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #27 +/- ##
==========================================
- Coverage 90.52% 90.10% -0.42%
==========================================
Files 11 10 -1
Lines 190 182 -8
Branches 19 18 -1
==========================================
- Hits 172 164 -8
Misses 13 13
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PowerKit(0.0.0-a.3) toDirectory.Packages.propsPolyShimfrom 2.7.0 to 2.9.0 inDirectory.Packages.propsPowerKitreference (PrivateAssets="all") toGress.csprojGress/Utils/Box.csProgressExtensions.cs: replaceBox<T>→Cell<T>, removeusing Gress.Utils, renamelastValueBox→lastValueCelldotnet buildsucceeds (full solution, 0 warnings, 0 errors)