Skip to content

Add PowerKit; replace hand-rolled Box<T> with Cell<T>#27

Merged
Tyrrrz merged 2 commits intoprimefrom
copilot/add-powerkit-and-replace-utilities
Apr 16, 2026
Merged

Add PowerKit; replace hand-rolled Box<T> with Cell<T>#27
Tyrrrz merged 2 commits intoprimefrom
copilot/add-powerkit-and-replace-utilities

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

  • Add PowerKit (0.0.0-a.3) to Directory.Packages.props
  • Update PolyShim from 2.7.0 to 2.9.0 in Directory.Packages.props
  • Add PowerKit reference (PrivateAssets="all") to Gress.csproj
  • Delete Gress/Utils/Box.cs
  • Update ProgressExtensions.cs: replace Box<T>Cell<T>, remove using Gress.Utils, rename lastValueBoxlastValueCell
  • Upgrade Avalonia 11.3.13 → 11.3.14 (fixes NU1903 build error; Tmds.DBus.Protocol 0.21.2 → 0.21.3)
  • dotnet build succeeds (full solution, 0 warnings, 0 errors)

…Box to lastValueCell

Agent-Logs-Url: https://github.com/Tyrrrz/Gress/sessions/66893970-eb79-4fe3-bb9f-01ff07aab45f

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
@Tyrrrz Tyrrrz added the enhancement New feature or request label Apr 16, 2026
@Tyrrrz Tyrrrz marked this pull request as ready for review April 16, 2026 09:46
Copilot AI review requested due to automatic review settings April 16, 2026 09:46
@Tyrrrz
Copy link
Copy Markdown
Owner

Tyrrrz commented Apr 16, 2026

@copilot build fails

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces PowerKit as a source-only (dev) dependency and replaces the project’s internal Box<T> helper with PowerKit’s Cell<T>, while also bumping PolyShim to the version required by PowerKit.

Changes:

  • Add PowerKit (dev-only) package reference and central package version.
  • Update ProgressExtensions to use PowerKit.Cell<T> instead of Gress.Utils.Box<T>.
  • Remove the now-redundant Gress/Utils/Box.cs implementation and bump PolyShim to 2.9.0.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Directory.Packages.props Adds PowerKit version and bumps PolyShim to align dependencies.
Gress/Gress.csproj References PowerKit with PrivateAssets="all" to keep it non-transitive.
Gress/Utils/Box.cs Deletes the hand-rolled container type now replaced by PowerKit.
Gress/ProgressExtensions.cs Swaps Box<T> usage for Cell<T> and updates the using directive.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

….DBus.Protocol 0.21.3

Agent-Logs-Url: https://github.com/Tyrrrz/Gress/sessions/5b4b62ac-88dc-4538-b546-9929bc05c555

Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 16, 2026

@copilot build fails

Fixed in be5a1bc. Avalonia.Desktop 11.3.13 pulled in Tmds.DBus.Protocol 0.21.2 (GHSA-xrw6-gwf8-vvr9), which was being treated as a build error via TreatWarningsAsErrors. Bumped all Avalonia packages from 11.3.13 → 11.3.14, which uses the patched Tmds.DBus.Protocol 0.21.3. Full solution now builds without errors.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • av-build-tel-api-v1.avaloniaui.net
    • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.2/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from Tyrrrz April 16, 2026 09:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.10%. Comparing base (2c199c6) to head (be5a1bc).
⚠️ Report is 1 commits behind head on prime.

Additional details and impacted files
@@            Coverage Diff             @@
##            prime      #27      +/-   ##
==========================================
- Coverage   90.52%   90.10%   -0.42%     
==========================================
  Files          11       10       -1     
  Lines         190      182       -8     
  Branches       19       18       -1     
==========================================
- Hits          172      164       -8     
  Misses         13       13              
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants