fix animations for headings and indents#67
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewlipski
requested changes
Nov 28, 2022
| }, | ||
|
|
||
| /* | ||
| TODO: this is not necessary? |
Collaborator
There was a problem hiding this comment.
I looked deeper into this and I'm only more confused regarding how node views work, it's probably best to jump on call to discuss this.
…restructuring-animations
matthewlipski
added a commit
that referenced
this pull request
Dec 7, 2022
* Restructured text & heading blocks (excluding drag handle add implementation) * Small cleanup * Cleaned up drag handle code * Added basic list item implementation * Updated block commands and keyboard handling * Added ordered list item indexing * Finished block manipulation logic * Fixed bug causing suggestion menu to not work properly in list item blocks * Refactoring changes * Minor fix * fix animations for headings and indents (#67) * fix animations for headings and indents * remove submodule * fix css * Fixed bug where splitting a block created an additional empty block * Cleaned up drag handle code * Fixed bug where the suggestion plugin tried to process transactions created by the ordered list indexing plugin * Improvements to block content naming and file structure * Code style changes and small fix to block keyboard shortcuts * Fixed bugs regarding selection when deleting blocks and using the suggestion menu with the keyboard * Block content attribute naming fixes * Fixed list item copy/pasting within the editor * Updated element selectors for tests * Updated snapshots for copy/paste and drag/drop tests * Adjusted enter key handler behavior * Changed ordered list item indices to start at 1 instead of 0 * Fixed list styling (no animations) * Updated remaining test snapshots * try clean playwright cache * Fixed bug where splitting a block duplicates its ID * Fixed bug where ordered list item indices were being updated unnecessarily * clean up OrderedListItemIndexPlugin * Fixed animation issue caused by change in naming convention * Added animations for unordered lists * Added animations for ordered lists * Added dispatch to block commands * Made backspace revert all block typing instead of just list items * Removed redundant conditions in block keyboard handlers * Changed ordered list index type from number to string in plugin * Optimized `getPosFromBlock` function * Fixed multiple block dragging * Improved transaction filtering for `PreviousBlockTypePlugin` * Improved paste behaviour for content outside the editor * Removed dispatch calls from block commands * Added edge cases for block commands (not currently being triggered) * Added test for Enter keyboard handler with selection spanning multiple blocks * Added functions to allow testing block IDs * Tests in which blocks are deleted/moved now verify block IDs * Added updated snapshots * Added updated screenshots for drag handle menu * Removed `joinBackward` as it is no longer used * Improved paste reliability from other sites, broke inline styles. * Improved paste reliability from other sites, broke inline styles. * Revert "Improved paste reliability from other sites, broke inline styles." This reverts commit 5c5c448. * Small fixes * Improved block ID mocking implementation. * Updated snapshot Co-authored-by: Yousef <yousefdardiry@gmail.com> Co-authored-by: Matthew Lipski <matthewlipski@Matthews-Mac-mini.local>
fogle
pushed a commit
to fogle/BlockNote
that referenced
this pull request
May 20, 2023
* Restructured text & heading blocks (excluding drag handle add implementation) * Small cleanup * Cleaned up drag handle code * Added basic list item implementation * Updated block commands and keyboard handling * Added ordered list item indexing * Finished block manipulation logic * Fixed bug causing suggestion menu to not work properly in list item blocks * Refactoring changes * Minor fix * fix animations for headings and indents (TypeCellOS#67) * fix animations for headings and indents * remove submodule * fix css * Fixed bug where splitting a block created an additional empty block * Cleaned up drag handle code * Fixed bug where the suggestion plugin tried to process transactions created by the ordered list indexing plugin * Improvements to block content naming and file structure * Code style changes and small fix to block keyboard shortcuts * Fixed bugs regarding selection when deleting blocks and using the suggestion menu with the keyboard * Block content attribute naming fixes * Fixed list item copy/pasting within the editor * Updated element selectors for tests * Updated snapshots for copy/paste and drag/drop tests * Adjusted enter key handler behavior * Changed ordered list item indices to start at 1 instead of 0 * Fixed list styling (no animations) * Updated remaining test snapshots * try clean playwright cache * Fixed bug where splitting a block duplicates its ID * Fixed bug where ordered list item indices were being updated unnecessarily * clean up OrderedListItemIndexPlugin * Fixed animation issue caused by change in naming convention * Added animations for unordered lists * Added animations for ordered lists * Added dispatch to block commands * Made backspace revert all block typing instead of just list items * Removed redundant conditions in block keyboard handlers * Changed ordered list index type from number to string in plugin * Optimized `getPosFromBlock` function * Fixed multiple block dragging * Improved transaction filtering for `PreviousBlockTypePlugin` * Improved paste behaviour for content outside the editor * Removed dispatch calls from block commands * Added edge cases for block commands (not currently being triggered) * Added test for Enter keyboard handler with selection spanning multiple blocks * Added functions to allow testing block IDs * Tests in which blocks are deleted/moved now verify block IDs * Added updated snapshots * Added updated screenshots for drag handle menu * Removed `joinBackward` as it is no longer used * Improved paste reliability from other sites, broke inline styles. * Improved paste reliability from other sites, broke inline styles. * Revert "Improved paste reliability from other sites, broke inline styles." This reverts commit 5c5c448. * Small fixes * Improved block ID mocking implementation. * Updated snapshot Co-authored-by: Yousef <yousefdardiry@gmail.com> Co-authored-by: Matthew Lipski <matthewlipski@Matthews-Mac-mini.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
There are also some notes in the code we should discuss before merging. Steps after this are to work on lists (animations + keyboard behavior)