refactor(trogon-nats): use per-operation traits with ToSubject

[yordis]

No description provided.

[cursor]

PR Summary

Medium Risk
Signature changes are source-breaking for downstream crates and could require widespread call-site updates, but behavior changes are limited to subject type handling and mocks.

Overview
Refactors the per-operation NATS client traits (SubscribeClient, RequestClient, PublishClient) to accept any async_nats::subject::ToSubject instead of requiring a String, aligning the abstraction with async_nats and reducing caller allocations.

Updates the NatsAsyncClient impls, mock clients, and unit tests to use the new generic subject parameter, and re-exports ToSubject from the crate root for easier downstream use.

^{Written by Cursor Bugbot for commit 41c5076. This will update automatically on new commits. Configure here.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The NATS client traits (SubscribeClient, RequestClient, PublishClient) are generalized to accept subject parameters as any type implementing ToSubject + Send, rather than requiring String. The ToSubject trait is re-exported at the crate root, and mock implementations are updated to support the new generic signatures with subject conversion.

Changes

Cohort / File(s)	Summary
Core Trait Abstractions rsworkspace/crates/trogon-nats/src/client.rs	Updated trait method signatures (subscribe, request_with_headers, publish_with_headers) to use generic subject parameter S: ToSubject + Send instead of String. Adjusted implementations to pass generic subjects directly to underlying async_nats methods.
Public Re-exports rsworkspace/crates/trogon-nats/src/lib.rs	Added public re-export of ToSubject trait from the async_nats crate to enable users to implement and pass custom subject types.
Mock Implementations rsworkspace/crates/trogon-nats/src/mocks.rs	Updated MockNatsClient and AdvancedMockNatsClient to implement generic trait methods with subject conversion via to_subject().to_string(). Adjusted internal storage and message construction to work with stringified subjects.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit hops through generic bounds,
Where subjects dance as flexible rounds,
No longer strings of static chain,
But traits that flow like autumn rain,
The code now bends yet holds its reins! 🌿

✨ Finishing Touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-sub

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}